From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv5 09/10] DTS: ARM: OMAP3-N900: Add SSI support Date: Tue, 27 May 2014 13:35:44 -0700 Message-ID: <20140527203543.GB32336@atomide.com> References: <1399739870-13526-1-git-send-email-sre@kernel.org> <1399739870-13526-10-git-send-email-sre@kernel.org> <20140514215503.GM27426@atomide.com> <20140520003538.GD15793@atomide.com> <20140521182513.GA26285@earth.universe> <20140521184319.GL17417@atomide.com> <20140521194527.GM17417@atomide.com> <20140521215055.GA26362@earth.universe> <20140521220807.GB14520@atomide.com> <20140522000558.GC29118@earth.universe> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140522000558.GC29118-SfvFxonMDyemK9LvCR3Hrw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Reichel Cc: Linus Walleij , Shubhrajyoti Datta , Carlos Chinea , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pali =?utf-8?B?Um9ow6Fy?= , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , Joni Lapilainen , Aaro Koskinen , Pavel Machek , Paul Walmsley List-Id: devicetree@vger.kernel.org * Sebastian Reichel [140521 17:06]: > On Wed, May 21, 2014 at 03:08:07PM -0700, Tony Lindgren wrote: > > * Sebastian Reichel [140521 14:51]: > > > > > > Feel free to add Tested-by/Acked-By to the hwmod patch. > > > > OK thanks for testing. > > You are welcome. > > > I'll apply your dts changes as soon as I have an ack from Paul on > > the hwmod changes. Probably best to queue them together to avoid > > PM breaking. > > Ok. Sounds legit. Based on chatting with Paul it seems that we most likely don't have bits for sysc_flags for SYSC_HAS_EMUFREE or SYSS_HAS_RESET_STATUS either. So applying the updated patch below, and the SSI dts changes into omap-for-v3.16/dt-v2. I'm keeping your previous ack Sebastian as the the idlemodes did not change from the previous version, hopefully that's OK with you. Regards, Tony 8< ------------------ From: Tony Lindgren Date: Wed, 21 May 2014 12:31:35 -0700 Subject: [PATCH] ARM: OMAP2+: Fix ssi hwmod entry to allow idling The current entry prevents system from idling if the hwmod is defined in the .dts file so let's change the idlemodes. Note that we probably don't have SYSC_HAS_EMUFREE or SYSS_HAS_RESET_STATUS either. If we do, those can be added later on. Acked-by: Sebastian Reichel Signed-off-by: Tony Lindgren --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c @@ -3689,12 +3689,9 @@ static struct omap_hwmod_class_sysconfig omap34xx_ssi_sysc = { .rev_offs = 0x0000, .sysc_offs = 0x0010, .syss_offs = 0x0014, - .sysc_flags = (SYSC_HAS_AUTOIDLE | SYSC_HAS_EMUFREE | - SYSC_HAS_MIDLEMODE | SYSC_HAS_SIDLEMODE | - SYSC_HAS_SOFTRESET | SYSS_HAS_RESET_STATUS), - .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART | - SIDLE_SMART_WKUP | MSTANDBY_FORCE | MSTANDBY_NO | - MSTANDBY_SMART | MSTANDBY_SMART_WKUP), + .sysc_flags = (SYSC_HAS_AUTOIDLE | SYSC_HAS_MIDLEMODE | + SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET), + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), .sysc_fields = &omap_hwmod_sysc_type1, }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html