devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Antoine Ténart" <antoine.tenart@free-electrons.com>
Cc: thomas.petazzoni@free-electrons.com, Andrew Lunn <andrew@lunn.ch>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	zmxu@marvell.com, alexandre.belloni@free-electrons.com,
	jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
	sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH 2/2] ARM: dts: berlin: enable i2c0 and i2c2
Date: Wed, 4 Jun 2014 19:03:40 +0200	[thread overview]
Message-ID: <20140604170340.GI6892@lunn.ch> (raw)
In-Reply-To: <20140604164841.GA12859@kwain>

On Wed, Jun 04, 2014 at 06:48:41PM +0200, Antoine Ténart wrote:
> Hi Andrew,
> 
> On Tue, Jun 03, 2014 at 10:05:22AM +0200, Andrew Lunn wrote:
> > On Tue, Jun 03, 2014 at 09:33:10AM +0200, Antoine Ténart wrote:
> > > Enable the I2C0 and I2C2 for the Marvell Berlin BG2G DMP. I2C1 and I2C3
> > > are also working on this board, but no devices seemed to be there.
> > 
> > Does this mean that IC0 and I2C2 have devices on them? Could you also
> > add nodes for the devices?
> 
> No devices I can add for now. I you prefer we can drop this patch, keep
> the other one and enable i2c nodes for the BG2Q DMP when they will be
> needed.

Hi Antoine

I was just wondering how you tested it, without having any devices?
Is it that the devices on the bus don't have mainline drivers?

I don't see a reason not to commit both. At least it allows i2c-detect
to work and see what is on the bus, even if we cannot drive them.

Thanks
	Andrew

  reply	other threads:[~2014-06-04 17:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-03  7:33 [PATCH 0/2] ARM: berlin: BG2Q I2C support Antoine Ténart
2014-06-03  7:33 ` [PATCH 1/2] ARM: dts: berlin: add I2C nodes for BG2Q Antoine Ténart
2014-06-16 11:22   ` Sebastian Hesselbarth
2014-06-03  7:33 ` [PATCH 2/2] ARM: dts: berlin: enable i2c0 and i2c2 Antoine Ténart
     [not found]   ` <1401780790-17830-3-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-06-03  8:05     ` Andrew Lunn
2014-06-04 16:48       ` Antoine Ténart
2014-06-04 17:03         ` Andrew Lunn [this message]
2014-06-04 17:37           ` Antoine Ténart
2014-06-16 11:23   ` Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140604170340.GI6892@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=antoine.tenart@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=zmxu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).