From: Tejun Heo <tj@kernel.org>
To: Suman Tripathi <stripathi@apm.com>
Cc: olof@lixom.net, arnd@arndb.de, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ddutile@redhat.com,
jcm@redhat.com, patches@apm.com, Loc Ho <lho@apm.com>
Subject: Re: [PATCH v0 2/2] ata: Fix the dma state machine lockup for the PIO mode commands.
Date: Fri, 6 Jun 2014 18:30:57 -0400 [thread overview]
Message-ID: <20140606223057.GB1055@mtj.dyndns.org> (raw)
In-Reply-To: <1402090134-23164-3-git-send-email-stripathi@apm.com>
On Sat, Jun 07, 2014 at 02:58:54AM +0530, Suman Tripathi wrote:
> @@ -5072,6 +5072,16 @@ int ata_qc_complete_multiple(struct ata_port *ap, u32 qc_active)
> if (qc) {
> ata_qc_complete(qc);
> nr_done++;
> + /*
> + * Some controller unable to clear the BSY bit after
> + * receiving the PIO Setup FIS from device resulting
> + * the DMA state to go into CMFatalErrorUpdate state.
> + * So need to restart the dma engine to get the
> + * controller out of this state.
> + */
> + if ((ap->flags & ATA_HORKAGE_BROKEN_PIO_CMD) &&
> + (qc->tf.protocol == ATA_PROT_PIO))
> + ap->ops->restart_engine(ap);
Why aren't you doing this by wrapping irq handler?
Thanks.
--
tejun
prev parent reply other threads:[~2014-06-06 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 21:28 [PATCH v0 0/2]ata: Fix the dma state machine lockup for APM X-Gene SoC Suman Tripathi
2014-06-06 21:28 ` [PATCH v0 1/2] libahci: Implement the function restart_engine to restart the port dma engine Suman Tripathi
2014-06-06 22:29 ` Tejun Heo
2014-06-06 21:28 ` [PATCH v0 2/2] ata: Fix the dma state machine lockup for the PIO mode commands Suman Tripathi
2014-06-06 22:30 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140606223057.GB1055@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).