From: Guenter Roeck <linux@roeck-us.net>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Heiko Schocher <hs@denx.de>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
Jean Delvare <khali@linux-fr.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor
Date: Tue, 17 Jun 2014 09:21:14 -0700 [thread overview]
Message-ID: <20140617162114.GA23451@roeck-us.net> (raw)
In-Reply-To: <20140617161105.GF8930@leverpostej>
On Tue, Jun 17, 2014 at 05:11:05PM +0100, Mark Rutland wrote:
> On Tue, Jun 17, 2014 at 09:11:53AM +0100, Heiko Schocher wrote:
> > Driver for the TI TMP103.
> >
> > The TI TMP103 is similar to the TMP102. It differs from the TMP102
> > by having only 8 bit registers.
> >
> > Signed-off-by: Heiko Schocher <hs@denx.de>
> >
[ ... ]
> > +
> > +static const struct i2c_device_id tmp103_id[] = {
> > + { DRIVER_NAME, 0 },
>
> This seems to be used for compatible string matching. As such, I think
> it would make more sense to have the string in full here so as to
> discourage it from being changed arbitrarily in future.
>
Makes sense. Heiko, can you change that as well in v5 ?
It also simplifies adding another chip to the driver, should that
ever happen.
Thanks,
Guenter
prev parent reply other threads:[~2014-06-17 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 8:11 [PATCH v4] hwmon: Driver for TI TMP103 temperature sensor Heiko Schocher
2014-06-17 10:48 ` Guenter Roeck
[not found] ` <53A01CE6.4010608-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-06-17 11:01 ` Heiko Schocher
2014-06-17 14:22 ` Guenter Roeck
2014-06-17 16:11 ` Mark Rutland
2014-06-17 16:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617162114.GA23451@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=hs@denx.de \
--cc=khali@linux-fr.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).