From: Tejun Heo <tj@kernel.org>
To: Suman Tripathi <stripathi@apm.com>
Cc: olof@lixom.net, arnd@arndb.de, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ddutile@redhat.com,
jcm@redhat.com, patches@apm.com
Subject: Re: [PATCH v2 1/2] libahci: Implement the function ahci_restart_engine to restart the port dma engine.
Date: Tue, 17 Jun 2014 12:21:56 -0400 [thread overview]
Message-ID: <20140617162156.GI31819@htj.dyndns.org> (raw)
In-Reply-To: <1402911336-31788-2-git-send-email-stripathi@apm.com>
Hello,
On Mon, Jun 16, 2014 at 03:05:35PM +0530, Suman Tripathi wrote:
> This patch implements the function ahci_restart_engine function to restart the port dma engine.
Please fit the text under 80 column.
> ---
I can't apply w/o your SOB.
> +int ahci_restart_engine(struct ata_port *ap)
> +{
> + ahci_stop_engine(ap);
> + ahci_start_fis_rx(ap);
> + ahci_start_engine(ap);
> +
> + return 0;
> +}
> +EXPORT_SYMBOL_GPL(ahci_restart_engine);
Why is this exported? The next patch doesn't seem to use the function
outside libahci.c proper.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-06-17 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 9:35 [PATCH v2 0/2]ata: Fix the dma state machine lockup for APM X-Gene SoC Suman Tripathi
2014-06-16 9:35 ` [PATCH v2 1/2] libahci: Implement the function ahci_restart_engine to restart the port dma engine Suman Tripathi
2014-06-17 16:21 ` Tejun Heo [this message]
2014-06-16 9:35 ` [PATCH v2 2/2] ata: Fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode command Suman Tripathi
2014-06-17 16:31 ` Tejun Heo
2014-06-16 15:59 ` [PATCH v2 0/2]ata: Fix the dma state machine lockup for APM X-Gene SoC Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140617162156.GI31819@htj.dyndns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=ddutile@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).