From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Mark Brown <broonie@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Mike Turquette <mturquette@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Kukjin Kim <kgene.kim@samsung.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Daniel Stone <daniels@collabora.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC
Date: Wed, 18 Jun 2014 09:32:04 +0100 [thread overview]
Message-ID: <20140618083204.GP21030@lee--X1> (raw)
In-Reply-To: <53A01F09.5070106@collabora.co.uk>
> >> +config MFD_MAX77802
> >> + tristate "Maxim Integrated MAX77802 PMIC Support"
> >> + depends on I2C=y
> >> + select MFD_CORE
> >> + select REGMAP_I2C
> >> + select REGMAP_IRQ
> >> + select IRQ_DOMAIN
> >> + help
> >> + Say yes here to support for Maxim Integrated MAX77802.
> >> + This is a Power Management IC with RTC on chip.
> >> + This driver provides common support for accessing the device;
> >> + additional drivers must be enabled in order to use the functionality
> >> + of the device.
> >> +
> >
> > It is a bit unorthodox to put the build infrastructure in the same patch
> > as the DT binding...
> >
>
> I thought it was the opposite. That a DT binding document has to be added along
> with the first user of the binding but I'll separate the DT doc in another patch
> then if that is the right thing to do.
This was the 'old' method, but changed a little over a year ago.
> Thanks a lot for all your suggestions, I'll wait a little to see if there is
> more feedback and repost a v3 addressing all the issues you pointed out.
Just re-post it. I'll review the next version.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-06-18 8:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 18:02 [PATCH v2 00/10] Add Maxim 77802 PMIC support Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 01/10] mfd: max77686: Convert to use regmap_irq Javier Martinez Canillas
2014-06-17 20:32 ` Lee Jones
2014-06-17 20:57 ` Doug Anderson
2014-06-18 9:21 ` Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 02/10] clk: max77686: add DT include for MAX77686 PMIC clock Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 03/10] Documentation: dt: improve Maxim 77686 PMIC clocks binding Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 04/10] clk: Add generic driver for Maxim PMIC clocks Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 05/10] clk: max77686: convert to the generic max clock driver Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 06/10] mfd: Add driver for Maxim 77802 Power Management IC Javier Martinez Canillas
2014-06-16 19:27 ` Mark Brown
2014-06-17 10:57 ` Javier Martinez Canillas
2014-06-18 8:32 ` Lee Jones [this message]
2014-06-18 9:50 ` Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators Javier Martinez Canillas
2014-06-16 19:25 ` Mark Brown
[not found] ` <20140616192500.GJ5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-17 10:49 ` Javier Martinez Canillas
2014-06-17 14:12 ` Mark Brown
2014-06-17 16:05 ` Javier Martinez Canillas
2014-06-21 20:40 ` Mark Brown
2014-06-23 9:28 ` Javier Martinez Canillas
[not found] ` <53A7F339.7050608-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2014-06-23 9:47 ` Mark Brown
2014-06-24 16:43 ` Javier Martinez Canillas
2014-06-17 21:17 ` Lee Jones
2014-06-18 9:47 ` Javier Martinez Canillas
2014-06-18 14:10 ` Lee Jones
2014-06-19 13:32 ` Alessandro Zummo
2014-06-16 18:02 ` [PATCH v2 08/10] clk: Add driver for Maxim 77802 PMIC clocks Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 09/10] rtc: Add driver for Maxim 77802 PMIC Real-Time-Clock Javier Martinez Canillas
2014-06-16 18:02 ` [PATCH v2 10/10] ARM: dts: Add max77802 device node for exynos5420-peach-pit Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618083204.GP21030@lee--X1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=daniels@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=olof@lixom.net \
--cc=sameo@linux.intel.com \
--cc=sjoerd.simons@collabora.co.uk \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).