From: Mark Rutland <mark.rutland@arm.com>
To: Varka Bhadram <varkabhadram@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"alex.bluesman.smirnov@gmail.com"
<alex.bluesman.smirnov@gmail.com>,
"dbaryshkov@gmail.com" <dbaryshkov@gmail.com>,
"linux-zigbee-devel@lists.sourceforge.net"
<linux-zigbee-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH net-next v2 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio
Date: Wed, 18 Jun 2014 14:39:58 +0100 [thread overview]
Message-ID: <20140618133958.GC11895@leverpostej> (raw)
In-Reply-To: <53A17442.8010009@gmail.com>
On Wed, Jun 18, 2014 at 12:13:06PM +0100, Varka Bhadram wrote:
> On 06/18/2014 03:25 PM, Mark Rutland wrote:
> > On Wed, Jun 18, 2014 at 10:26:16AM +0100, Varka Bhadram wrote:
> >> +static int cc2520_probe(struct spi_device *spi)
> >> +{
> >> + struct cc2520_private *priv;
> >> + struct pinctrl *pinctrl;
> >> + struct cc2520_platform_data *pdata;
> >> + struct device_node __maybe_unused *np = spi->dev.of_node;
> >>
> >> This looks to be definitely unused rather than __maybe_unused. There are
> >> no other occuences of "np" in this function.
> >>
> >> This macro defined like this.
> >> #define __maybe_unused __attribute__((unused))
> > Sure, but that's irrelevant. There's absolutely no point in this
> > variable existing at all, and it can simply disappear.
> >
> > Mark.
>
> If we don't use that macro the compiler triggers warnings saying that: warning: unused variable ‘np’ [-Wunused-variable]
Then drop the _variable_, not just the annotation.
Mark.
next prev parent reply other threads:[~2014-06-18 13:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 5:16 [PATCH net-next v2 0/3] Driver fir TI CC2520 Radio Varka Bhadram
2014-06-18 5:16 ` [PATCH net-next v2 1/3] ieee802154: cc2520: adds driver for TI CC2520 radio Varka Bhadram
2014-06-18 9:10 ` Mark Rutland
2014-06-18 9:26 ` Varka Bhadram
[not found] ` <53A15B38.6060404-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-18 9:55 ` Mark Rutland
2014-06-18 11:13 ` Varka Bhadram
2014-06-18 13:39 ` Mark Rutland [this message]
[not found] ` <1403068565-32224-1-git-send-email-varkab-If5XQcfNmg0@public.gmane.org>
2014-06-18 5:16 ` [PATCH net-next v2 2/3] ieee802154: cc2520: add driver to kernel build system Varka Bhadram
2014-06-18 5:16 ` [PATCH net-next v2 3/3] devicetree: add devicetree bindings for cc2520 driver Varka Bhadram
2014-06-18 9:05 ` Mark Rutland
2014-06-18 9:11 ` Varka Bhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618133958.GC11895@leverpostej \
--to=mark.rutland@arm.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=davem@davemloft.net \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).