Re: [PATCH v11 3/8] ASoC: generic: simple DT sound card

Re: [PATCH v11 3/8] ASoC: generic: simple DT sound card

[Markus Pargmann]

Hi,

On Fri, Aug 23, 2013 at 10:58:16AM +0100, Mark Brown wrote:
> On Mon, Aug 19, 2013 at 05:05:56PM +0200, Markus Pargmann wrote:
> > Simple sound card initialized using DT. When used with AC97, ac97-codec
> > is used to automatically discover the used codec.
> 
> I've held back a bit on this one.  The reason is that it's adding a
> separate card to the generic card which doesn't seem like the obvious
> thing to do - obviously they have very similar goals, it's just that one
> is for DT usage and the other isn't.  What's the reason for not adding
> DT support to the generic card?

There was no code I could reuse from the existing simple card driver, so
I decided to seperate the DT part.

I will move the DT driver code into simple card and resend the patch.

Thanks,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH v11 2/8] ASoC: core: Generic ac97 link reset functions

[S. Fricke]

Hi Markus,

I'm fighting with your ac97 pinctrl configuration per dts. 

> [...]
> +ssi {
> +	...
> +
> +	pinctrl-names = "default", "ac97-running", "ac97-reset", "ac97-warm-reset";
> +	pinctrl-0 = <&ac97link_running>;
> +	pinctrl-1 = <&ac97link_running>;
> +	pinctrl-2 = <&ac97link_reset>;
> +	pinctrl-3 = <&ac97link_warm_reset>;
> +	ac97-gpios = <&gpio3 20 0 &gpio3 22 0 &gpio3 28 0>;

I see here the gpios for sync, sdata and reset. On my board I have two sdata
lines (sdata-in and sdata-out) which line should I specify here for this setting?

Thanks for a short answer and
Cheers, Silvio


-- 
-- S. Fricke ---------------------------------------- silvio-lOxvEG+uzzjk1uMJSBkQmQ@public.gmane.org --
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v11 2/8] ASoC: core: Generic ac97 link reset functions

[Markus Pargmann]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Hi Silvio,

On Wed, Jun 18, 2014 at 08:42:34PM +0200, S. Fricke wrote:
> 
> Hi Markus,
> 
> I'm fighting with your ac97 pinctrl configuration per dts. 
> 
> > [...]
> > +ssi {
> > +	...
> > +
> > +	pinctrl-names = "default", "ac97-running", "ac97-reset", "ac97-warm-reset";
> > +	pinctrl-0 = <&ac97link_running>;
> > +	pinctrl-1 = <&ac97link_running>;
> > +	pinctrl-2 = <&ac97link_reset>;
> > +	pinctrl-3 = <&ac97link_warm_reset>;
> > +	ac97-gpios = <&gpio3 20 0 &gpio3 22 0 &gpio3 28 0>;
> 
> I see here the gpios for sync, sdata and reset. On my board I have two sdata
> lines (sdata-in and sdata-out) which line should I specify here for this setting?

Try to use sdata-out. This is the only data output line. sdata-in is the
input to the SoC so we don't have to use this for an AC97 reset.

Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]