From: Peter Griffin <peter.griffin@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
kernel@stlinux.com, devicetree@vger.kernel.org,
srinivas.kandagatla@gmail.com, thierry.reding@gmail.com
Subject: Re: [STLinux Kernel] [PATCH 1/7] ARM: stih407: Add DT nodes for for PWM
Date: Thu, 19 Jun 2014 09:38:35 +0100 [thread overview]
Message-ID: <20140619083835.GA2131@griffinp-ThinkPad-X1-Carbon-2nd> (raw)
In-Reply-To: <1403103172-19856-1-git-send-email-lee.jones@linaro.org>
Hi Lee,
> + /* SBC PWM Module */
> + pwm1: pwm@9510000 {
> + compatible = "st,sti-pwm";
> + status = "disabled";
> + #pwm-cells = <2>;
> + reg = <0x9510000 0x68>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1_chan0_default
> + &pinctrl_pwm1_chan1_default
> + &pinctrl_pwm1_chan2_default
> + &pinctrl_pwm1_chan3_default>;
If you're passing pin config for 4 channels, I think you should also be using the
'st,pwm-num-chan = <4>' property like the doc example in patch 7.
After that:
Acked-by: Peter Griffin <peter.griffin@linaro.org>
regards,
Peter.
prev parent reply other threads:[~2014-06-19 8:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 14:52 [PATCH 1/7] ARM: stih407: Add DT nodes for for PWM Lee Jones
2014-06-18 14:52 ` [PATCH 2/7] ARM: stih416: Add Pinctrl settings " Lee Jones
2014-06-18 14:52 ` [PATCH 3/7] ARM: stih416: Add DT nodes " Lee Jones
2014-06-18 15:08 ` Gabriel Fernandez
2014-06-18 15:17 ` Lee Jones
2014-06-18 15:28 ` [PATCH v2 " Lee Jones
2014-06-18 14:52 ` [PATCH 4/7] ARM: stih416-b2020e: Enable PWM on the B2020 Rev-E Lee Jones
2014-06-19 9:05 ` [STLinux Kernel] " Peter Griffin
2014-06-19 9:20 ` Lee Jones
2014-06-19 10:12 ` Peter Griffin
2014-06-19 10:59 ` Maxime Coquelin
2014-06-19 11:22 ` Lee Jones
2014-06-19 13:29 ` Peter Griffin
2014-06-18 14:52 ` [PATCH 5/7] ARM: multi_v7_defconfig: Enable ST's PWM driver Lee Jones
2014-06-18 14:52 ` [PATCH 6/7] pwm: st: Add new driver for ST's PWM IP Lee Jones
2014-06-18 23:11 ` Thierry Reding
2014-06-19 8:44 ` Lee Jones
2014-06-19 11:32 ` Russell King - ARM Linux
2014-06-19 14:27 ` Ajit Pal
[not found] ` <53A2F342.7030606-qxv4g6HH51o@public.gmane.org>
2014-06-20 22:27 ` Thierry Reding
2014-06-20 22:16 ` Thierry Reding
2014-06-18 14:52 ` [PATCH 7/7] pwm: st: Supply Device Tree binding documentation " Lee Jones
2014-06-18 15:08 ` Gabriel Fernandez
2014-06-18 15:16 ` Lee Jones
2014-06-18 15:29 ` [PATCH v2 " Lee Jones
2014-06-18 15:07 ` [PATCH 1/7] ARM: stih407: Add DT nodes for for PWM Gabriel Fernandez
2014-06-18 15:16 ` Lee Jones
2014-06-18 15:26 ` [PATCH v2 " Lee Jones
2014-06-19 8:38 ` Peter Griffin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140619083835.GA2131@griffinp-ThinkPad-X1-Carbon-2nd \
--to=peter.griffin@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=srinivas.kandagatla@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox