* [patch 0/2] dt: spear320: Make it work @ 2014-06-19 21:56 Thomas Gleixner 2014-06-19 21:56 ` [patch 1/2] dts: spear: Fix sdhci compatible Thomas Gleixner 2014-06-19 21:56 ` [patch 2/2] dts: spear: Add missing i2c1 interrupt Thomas Gleixner 0 siblings, 2 replies; 6+ messages in thread From: Thomas Gleixner @ 2014-06-19 21:56 UTC (permalink / raw) To: LKML Cc: Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, Viresh Kumar, spear-devel-nkJGhpqTU55BDgjK7y7TUQ The sdhci compatible does neither match the documentation nor the implementaion in the drivers and the i2c1 is missing an interrupt assignment. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch 1/2] dts: spear: Fix sdhci compatible 2014-06-19 21:56 [patch 0/2] dt: spear320: Make it work Thomas Gleixner @ 2014-06-19 21:56 ` Thomas Gleixner [not found] ` <20140619215557.784621009-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> 2014-06-19 21:56 ` [patch 2/2] dts: spear: Add missing i2c1 interrupt Thomas Gleixner 1 sibling, 1 reply; 6+ messages in thread From: Thomas Gleixner @ 2014-06-19 21:56 UTC (permalink / raw) To: LKML Cc: Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, Viresh Kumar, spear-devel-nkJGhpqTU55BDgjK7y7TUQ [-- Attachment #1: spear-dts-fix-sdhci-compatible.patch --] [-- Type: text/plain, Size: 852 bytes --] Make it match the bindings and the implementation. Signed-off-by: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> --- arch/arm/boot/dts/spear320.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/arch/arm/boot/dts/spear320.dtsi =================================================================== --- linux.orig/arch/arm/boot/dts/spear320.dtsi +++ linux/arch/arm/boot/dts/spear320.dtsi @@ -48,7 +48,7 @@ }; sdhci@70000000 { - compatible = "st,sdhci-spear"; + compatible = "st,spear300-sdhci"; reg = <0x70000000 0x100>; interrupts = <10>; interrupt-parent = <&shirq>; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20140619215557.784621009-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>]
* Re: [patch 1/2] dts: spear: Fix sdhci compatible [not found] ` <20140619215557.784621009-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> @ 2014-06-20 4:47 ` Viresh Kumar 0 siblings, 0 replies; 6+ messages in thread From: Viresh Kumar @ 2014-06-20 4:47 UTC (permalink / raw) To: Thomas Gleixner Cc: LKML, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, spear-devel On Fri, Jun 20, 2014 at 3:26 AM, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> wrote: > Make it match the bindings and the implementation. > > Signed-off-by: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> > --- > arch/arm/boot/dts/spear320.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/arch/arm/boot/dts/spear320.dtsi > =================================================================== > --- linux.orig/arch/arm/boot/dts/spear320.dtsi > +++ linux/arch/arm/boot/dts/spear320.dtsi > @@ -48,7 +48,7 @@ > }; > > sdhci@70000000 { > - compatible = "st,sdhci-spear"; > + compatible = "st,spear300-sdhci"; > reg = <0x70000000 0x100>; > interrupts = <10>; > interrupt-parent = <&shirq>; Acked-by: Viresh Kumar <viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch 2/2] dts: spear: Add missing i2c1 interrupt 2014-06-19 21:56 [patch 0/2] dt: spear320: Make it work Thomas Gleixner 2014-06-19 21:56 ` [patch 1/2] dts: spear: Fix sdhci compatible Thomas Gleixner @ 2014-06-19 21:56 ` Thomas Gleixner [not found] ` <20140619215557.875556819-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: Thomas Gleixner @ 2014-06-19 21:56 UTC (permalink / raw) To: LKML Cc: Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, Viresh Kumar, spear-devel-nkJGhpqTU55BDgjK7y7TUQ [-- Attachment #1: spear-dts-add-i2c1-interrupt.patch --] [-- Type: text/plain, Size: 834 bytes --] Signed-off-by: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> --- arch/arm/boot/dts/spear320.dtsi | 5 +++++ 1 file changed, 5 insertions(+) Index: linux/arch/arm/boot/dts/spear320.dtsi =================================================================== --- linux.orig/arch/arm/boot/dts/spear320.dtsi +++ linux/arch/arm/boot/dts/spear320.dtsi @@ -123,6 +123,11 @@ status = "disabled"; }; + i2c1: i2c@a7000000 { + interrupts = <21>; + interrupt-parent = <&shirq>; + }; + gpiopinctrl: gpio@b3000000 { compatible = "st,spear-plgpio"; reg = <0xb3000000 0x1000>; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20140619215557.875556819-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>]
* Re: [patch 2/2] dts: spear: Add missing i2c1 interrupt [not found] ` <20140619215557.875556819-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> @ 2014-06-20 4:42 ` Viresh Kumar [not found] ` <CAOh2x==eh=k-LWK89QY_B0f9e7ctZE035NQm_vumayBYf3Mtnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Viresh Kumar @ 2014-06-20 4:42 UTC (permalink / raw) To: Thomas Gleixner Cc: LKML, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, spear-devel On Fri, Jun 20, 2014 at 3:26 AM, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> wrote: > Signed-off-by: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> > --- > arch/arm/boot/dts/spear320.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > Index: linux/arch/arm/boot/dts/spear320.dtsi > =================================================================== > --- linux.orig/arch/arm/boot/dts/spear320.dtsi > +++ linux/arch/arm/boot/dts/spear320.dtsi > @@ -123,6 +123,11 @@ > status = "disabled"; > }; > > + i2c1: i2c@a7000000 { > + interrupts = <21>; > + interrupt-parent = <&shirq>; > + }; Isn't this already available ? i2c1: i2c@a7000000 { #address-cells = <1>; #size-cells = <0>; compatible = "snps,designware-i2c"; reg = <0xa7000000 0x1000>; interrupts = <21>; interrupt-parent = <&shirq>; status = "disabled"; }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAOh2x==eh=k-LWK89QY_B0f9e7ctZE035NQm_vumayBYf3Mtnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [patch 2/2] dts: spear: Add missing i2c1 interrupt [not found] ` <CAOh2x==eh=k-LWK89QY_B0f9e7ctZE035NQm_vumayBYf3Mtnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-06-20 7:52 ` Thomas Gleixner 0 siblings, 0 replies; 6+ messages in thread From: Thomas Gleixner @ 2014-06-20 7:52 UTC (permalink / raw) To: Viresh Kumar Cc: LKML, Rob Herring, devicetree-u79uwXL29TY76Z2rM5mHXA, spear-devel On Fri, 20 Jun 2014, Viresh Kumar wrote: > On Fri, Jun 20, 2014 at 3:26 AM, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> wrote: > > Signed-off-by: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> > > --- > > arch/arm/boot/dts/spear320.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > Index: linux/arch/arm/boot/dts/spear320.dtsi > > =================================================================== > > --- linux.orig/arch/arm/boot/dts/spear320.dtsi > > +++ linux/arch/arm/boot/dts/spear320.dtsi > > @@ -123,6 +123,11 @@ > > status = "disabled"; > > }; > > > > + i2c1: i2c@a7000000 { > > + interrupts = <21>; > > + interrupt-parent = <&shirq>; > > + }; > > Isn't this already available ? > > i2c1: i2c@a7000000 { > #address-cells = <1>; > #size-cells = <0>; > compatible = "snps,designware-i2c"; > reg = <0xa7000000 0x1000>; > interrupts = <21>; > interrupt-parent = <&shirq>; > status = "disabled"; > }; Oops yes, did this against an older tree and did not notice the duplicate. So nothing to do here. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-20 7:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-19 21:56 [patch 0/2] dt: spear320: Make it work Thomas Gleixner
2014-06-19 21:56 ` [patch 1/2] dts: spear: Fix sdhci compatible Thomas Gleixner
[not found] ` <20140619215557.784621009-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-06-20 4:47 ` Viresh Kumar
2014-06-19 21:56 ` [patch 2/2] dts: spear: Add missing i2c1 interrupt Thomas Gleixner
[not found] ` <20140619215557.875556819-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2014-06-20 4:42 ` Viresh Kumar
[not found] ` <CAOh2x==eh=k-LWK89QY_B0f9e7ctZE035NQm_vumayBYf3Mtnw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-20 7:52 ` Thomas Gleixner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).