* [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable
@ 2014-06-14 23:35 Rickard Strandqvist
2014-06-14 23:35 ` Rickard Strandqvist
0 siblings, 1 reply; 4+ messages in thread
From: Rickard Strandqvist @ 2014-06-14 23:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, Grant Likely
Cc: Fabio Estevam, devel, Rickard Strandqvist, Sascha Hauer,
Valentina Manea, linux-kernel, Paul Gortmaker, devicetree,
Rob Herring, Philipp Zabel, Russell King
Before when there was an error a uninitialized variable would be returnd.
Now it returns -ENODEV
This was found using a static code analysis program called cppcheck.
Rickard Strandqvist (1):
staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable
drivers/staging/imx-drm/ipu-v3/ipu-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.7.10.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable
2014-06-14 23:35 [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable Rickard Strandqvist
@ 2014-06-14 23:35 ` Rickard Strandqvist
2014-06-19 22:51 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Rickard Strandqvist @ 2014-06-14 23:35 UTC (permalink / raw)
To: Greg Kroah-Hartman, Grant Likely
Cc: Fabio Estevam, devel, Rickard Strandqvist, Sascha Hauer,
Valentina Manea, linux-kernel, Paul Gortmaker, devicetree,
Rob Herring, Philipp Zabel, Russell King
Before when there was an error a uninitialized variable would be returnd.
Now it returns -ENODEV
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/imx-drm/ipu-v3/ipu-common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3/ipu-common.c
index ca85d3d..468e364 100644
--- a/drivers/staging/imx-drm/ipu-v3/ipu-common.c
+++ b/drivers/staging/imx-drm/ipu-v3/ipu-common.c
@@ -1002,7 +1002,7 @@ static int ipu_add_client_devices(struct ipu_soc *ipu)
{
struct device *dev = ipu->dev;
unsigned i;
- int id, ret;
+ int id;
mutex_lock(&ipu_client_id_mutex);
id = ipu_client_id;
@@ -1025,7 +1025,7 @@ static int ipu_add_client_devices(struct ipu_soc *ipu)
err_register:
platform_device_unregister_children(to_platform_device(dev));
- return ret;
+ return -ENODEV;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable
2014-06-14 23:35 ` Rickard Strandqvist
@ 2014-06-19 22:51 ` Greg Kroah-Hartman
2014-06-20 11:20 ` Rickard Strandqvist
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2014-06-19 22:51 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Fabio Estevam, devel, devicetree, Sascha Hauer, Valentina Manea,
linux-kernel, Paul Gortmaker, Rob Herring, Philipp Zabel,
Grant Likely, Russell King
On Sun, Jun 15, 2014 at 01:35:21AM +0200, Rickard Strandqvist wrote:
> Before when there was an error a uninitialized variable would be returnd.
> Now it returns -ENODEV
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/imx-drm/ipu-v3/ipu-common.c | 4 ++--
This file isn't even in the tree anymore, what did you make this patch
against?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable
2014-06-19 22:51 ` Greg Kroah-Hartman
@ 2014-06-20 11:20 ` Rickard Strandqvist
0 siblings, 0 replies; 4+ messages in thread
From: Rickard Strandqvist @ 2014-06-20 11:20 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Fabio Estevam, devel, devicetree@vger.kernel.org, Sascha Hauer,
Valentina Manea, linux-kernel@vger.kernel.org, Paul Gortmaker,
Rob Herring, Philipp Zabel, Grant Likely, Russell King
Hi
The mainline form about Jun 6.
And now it is in drivers/gpu/ipu-v3/ipu-common.c
Still with the same error.
Sorry, I have started to compare to linux-next, but I do it as:
diff `find . ../linux-next/ -name ipu-common.c`
So missed that the file had moved :-/
Ok, I send a new patch then..
Kind regards
Rickard Strandqvist
2014-06-20 0:51 GMT+02:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Sun, Jun 15, 2014 at 01:35:21AM +0200, Rickard Strandqvist wrote:
>> Before when there was an error a uninitialized variable would be returnd.
>> Now it returns -ENODEV
>>
>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>> ---
>> drivers/staging/imx-drm/ipu-v3/ipu-common.c | 4 ++--
>
> This file isn't even in the tree anymore, what did you make this patch
> against?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-06-20 11:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-14 23:35 [PATCH] staging: imx-drm: ipu-v3: ipu-common.c: Cleaning up return of uninitialized variable Rickard Strandqvist
2014-06-14 23:35 ` Rickard Strandqvist
2014-06-19 22:51 ` Greg Kroah-Hartman
2014-06-20 11:20 ` Rickard Strandqvist
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).