From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
devicetree@vger.kernel.org,
"Antoine Ténart" <antoine.tenart@free-electrons.com>,
linux-kernel@vger.kernel.org, kishon@ti.com,
linux-ide@vger.kernel.org, alexandre.belloni@free-electrons.com,
jszhang@marvell.com, tj@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY
Date: Mon, 23 Jun 2014 15:05:19 +0200 [thread overview]
Message-ID: <20140623130519.GA23540@kwain> (raw)
In-Reply-To: <53A0861E.90400@gmail.com>
Sebastian,
On Tue, Jun 17, 2014 at 08:17:02PM +0200, Sebastian Hesselbarth wrote:
> On 06/16/2014 12:26 PM, Antoine Ténart wrote:
> > +
> > +#define PHY_BASE 0x200
>
> Antoine,
>
> I gave your Berlin AHCI patches a try on BG2. I finally got it working
> but BG2 has a different PHY_BASE and need some register fixups.
>
> Please update this patch and the DT bindings to reflect the difference
> of BG2Q with respect to BG2 as below.
>
> [...]
> > +
> > +static const struct of_device_id phy_berlin_sata_of_match[] = {
> > + { .compatible = "marvell,berlin-sata-phy" },
>
> s/marvell,berlin-sata-phy/marvell,berlin2-sata-phy/
>
> and add
>
> marvell,berlin2q-sata-phy
>
> That way it can be applied now without proper support for BG2
> and I can send patches later.
Sure. I'll just s/marvell,berlin-sata-phy/marvell,berlin2q-sata-phy/ so
we don't have a non working compatible.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-06-23 13:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 10:26 [PATCH v6 0/7] ARM: berlin: add AHCI support Antoine Ténart
2014-06-16 10:26 ` [PATCH v6 2/7] Documentation: bindings: add the Berlin SATA PHY Antoine Ténart
2014-06-16 10:26 ` [PATCH v6 3/7] ata: libahci: allow to use multiple PHYs Antoine Ténart
2014-06-16 10:26 ` [PATCH v6 4/7] ata: ahci_platform: add a generic AHCI compatible Antoine Ténart
2014-06-16 10:26 ` [PATCH v6 5/7] Documentation: bindings: document the sub-nodes AHCI bindings Antoine Ténart
2014-06-16 10:26 ` [PATCH v6 6/7] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart
2014-06-16 10:44 ` Sebastian Hesselbarth
2014-06-16 10:26 ` [PATCH v6 7/7] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart
[not found] ` <1402914392-6028-1-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-06-16 10:26 ` [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY Antoine Ténart
2014-06-17 18:17 ` Sebastian Hesselbarth
2014-06-23 13:05 ` Antoine Ténart [this message]
2014-06-24 12:00 ` Kishon Vijay Abraham I
2014-06-24 12:07 ` Varka Bhadram
2014-06-24 12:15 ` Lee Jones
2014-06-24 12:22 ` Varka Bhadram
2014-06-24 12:39 ` Lee Jones
2014-06-30 10:20 ` Antoine Ténart
2014-06-16 10:46 ` [PATCH v6 0/7] ARM: berlin: add AHCI support Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623130519.GA23540@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tj@kernel.org \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).