From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ioan.nicu.ext@nsn.com>
Date: Mon, 23 Jun 2014 20:33:50 +0200
From: Ioan Nicu <ioan.nicu.ext@nsn.com>
Subject: Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes
Message-ID: <20140623183343.GA10389@heimdall>
References: <1403430039-15085-1-git-send-email-pantelis.antoniou@konsulko.com>
 <1403430039-15085-6-git-send-email-pantelis.antoniou@konsulko.com>
 <53A85549.7040809@nsn.com>
 <6E91A461-4361-4A18-BE32-CECDD789C114@konsulko.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6E91A461-4361-4A18-BE32-CECDD789C114@konsulko.com>
To: ext Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nsn.com>, Grant Likely <grant.likely@secretlab.ca>, Rob Herring <robherring2@gmail.com>, Stephen Warren <swarren@wwwdotorg.org>, Matt Porter <matt.porter@linaro.org>, Koen Kooi <koen@dominion.thruhere.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Alison Chaiken <Alison_Chaiken@mentor.com>, Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>, Michael Stickel <ms@mycable.de>, Guenter Roeck <linux@roeck-us.net>, Dirk Behme <dirk.behme@gmail.com>, Alan Tull <delicious.quinoa@gmail.com>, Sascha Hauer <s.hauer@pengutronix.de>, Michael Bohan <mbohan@codeaurora.org>, Michal Simek <monstr@monstr.eu>, Matt Ranostay <mranostay@gmail.com>, Joel Becker <jlbec@evilplan.org>, devicetree@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org, Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Pete Popov <pete.popov@konsulko.com>, Dan Malek <dan.malek@konsulko.com>, Georgi Vlaev <georgi.vlaev@konsulko.com>
List-ID: <devicetree@vger.kernel.org>

Hi Pantelis,

On Mon, Jun 23, 2014 at 07:57:24PM +0300, ext Pantelis Antoniou wrote:
> Hi Alexander,
> 
> On Jun 23, 2014, at 7:26 PM, Alexander Sverdlin wrote:
> 
> > Hello Pantelis!
> > 
> > On 22/06/14 11:40, ext Pantelis Antoniou wrote:
> >> Introduce helper functions for working with the live DT tree,
> >> all of them related to dynamically adding/removing nodes and
> >> properties.
> >> 
> >> __of_copy_property() copies a property dynamically
> >> __of_create_empty_node() creates an empty node
> >> 
> >> Bug fix about prop->len == 0 by Ionut Nicu <ioan.nicu.ext@nsn.com>
> > 
> > Are you sure about this? (see below...)
> > 

Alexander is right, my fix was lost even though it's mentioned in this patch.

> >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> >> ---
> 
> [snip]
> >> +
> >> +	if (prop->length > 0) {
> >        ^^^^^^^^^^^^^^^^^^^^^
> > Seems, that length==0 case will still produce value==NULL results,
> > which will brake some checks in the kernel... Or am I missing something in
> > the new version?
> > 
> 
> prop->value will be set to NULL, and length will be set to zero (kzalloc).
> This is a normal zero length property.
> 
> I don't know of any place in the kernel accessing the value if prop->length==0
> 

We have a simple use case. We have an overlay which adds an interrupt controller.
If you look in drivers/of/irq.c, in of_irq_parse_raw():

[...]
	/* Now start the actual "proper" walk of the interrupt tree */
	while (ipar != NULL) {
		/* Now check if cursor is an interrupt-controller and if it is
		 * then we are done
		 */
		if (of_get_property(ipar, "interrupt-controller", NULL) !=
				NULL) {
			pr_debug(" -> got it !\n");
			return 0;
		}
[...]

A node is identified as an interrupt controller if it has a zero-length property
called "interrupt-controller" but with a non-NULL value.

My proposed fix for this was to remove the if () condition. propn->value will be
allocated with kmalloc(0) which returns ZERO_SIZE_PTR which is != NULL.


> 
> [snip]
> 
> >> +
> >> #endif /* _LINUX_OF_H */
> >> 
> > 
> > -- 
> > Best regards,
> > Alexander Sverdlin.
> 
> Regards
> 
> -- Pantelis
> 

Regards,
Ionut Nicu