From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v6 1/7] phy: add a driver for the Berlin SATA PHY Date: Tue, 24 Jun 2014 13:39:33 +0100 Message-ID: <20140624123933.GN13803@lee--X1> References: <1402914392-6028-1-git-send-email-antoine.tenart@free-electrons.com> <1402914392-6028-2-git-send-email-antoine.tenart@free-electrons.com> <53A9685E.9090501@ti.com> <53A96A1C.5030800@gmail.com> <20140624121525.GM13803@lee--X1> <53A96D68.8070303@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <53A96D68.8070303@gmail.com> Sender: linux-ide-owner@vger.kernel.org To: Varka Bhadram Cc: Kishon Vijay Abraham I , Antoine =?iso-8859-1?Q?T=E9nart?= , sebastian.hesselbarth@gmail.com, tj@kernel.org, alexandre.belloni@free-electrons.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov List-Id: devicetree@vger.kernel.org On Tue, 24 Jun 2014, Varka Bhadram wrote: > On 06/24/2014 05:45 PM, Lee Jones wrote: > >On Tue, 24 Jun 2014, Varka Bhadram wrote: > >>On 06/24/2014 05:30 PM, Kishon Vijay Abraham I wrote: > >>>On Monday 16 June 2014 03:56 PM, Antoine T=C3=A9nart wrote: > >>>>The Berlin SoC has a two SATA ports. Add a PHY driver to handle t= hem. > >>>> > >>>>The mode selection can let us think this PHY can be configured to= fit > >>>>other purposes. But there are reasons to think the SATA mode will= be > >>>>the only one usable: the PHY registers are only accessible indire= ctly > >>>>through two registers in the SATA range, the PHY seems to be inte= grated > >>>>and no information tells us the contrary. For these reasons, make= the > >>>>driver a SATA PHY driver. > >>>> > >>>>Signed-off-by: Antoine T=C3=A9nart > >>>>--- > >>>> drivers/phy/Kconfig | 7 ++ > >>>> drivers/phy/Makefile | 1 + > >>>> drivers/phy/phy-berlin-sata.c | 232 +++++++++++++++++++++++++++= +++++++++++++++ > >>>> 3 files changed, 240 insertions(+) > >>>> create mode 100644 drivers/phy/phy-berlin-sata.c >=20 > [...] >=20 > >>>>+static struct platform_driver phy_berlin_sata_driver =3D { > >>>>+ .probe =3D phy_berlin_sata_probe, > >>>>+ .driver =3D { > >>>>+ .name =3D "phy-berlin-sata", > >>>>+ .owner =3D THIS_MODULE, > >>>>+ .of_match_table =3D phy_berlin_sata_of_match, > >>use of_match_ptr for of_match_table > >What use is this? > > > >[...] > > > of_match_table is NULL for Non-DT based. Better to use the of_match_p= tr(). > If driver is DT based 'of_match_table =3D phy_berlin_sata_of_match' > else 'of_match_table =3D NULL' >=20 > This is take care by of_match_ptr() macro. This driver 'depends on OF', so it's okay to always populate =2Eof_match_table. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog