From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/4] phy: miphy365x: Add Device Tree bindings for the MiPHY365x Date: Tue, 24 Jun 2014 15:51:53 +0100 Message-ID: <20140624145153.GQ13803@lee--X1> References: <1400766819-22286-1-git-send-email-lee.jones@linaro.org> <6599289.0ZjjaMbRqj@wuerfel> <20140624124634.GO13803@lee--X1> <4274516.nCpbjAuUJp@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <4274516.nCpbjAuUJp@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Kishon Vijay Abraham I , Sergei Shtylyov , devicetree , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 24 Jun 2014, Arnd Bergmann wrote: > On Tuesday 24 June 2014 13:46:34 Lee Jones wrote: > > > > > > converting all addresses to to resources so drivers can eas= ily pull > > > > > > them out using platform_get_resource() and friends. Pushin= g the reg > > > > >=20 > > > > > right. Can't we use of_address_to_resource here? > > > >=20 > > > > We could, but that would be an extra layer. We'd be pulling th= e > > > > address, putting it into a resource, then pulling it from the r= esource > > > > for use. If we're going to be pulling addresses out manually, = we're > > > > probably better off using of_get_address(). But again, we're j= ust > > > > carrying out functionality which is already provided by the > > > > framework. > > >=20 > > > there is also of_ioremap(). > >=20 > > Isn't this SPARK only? And doesn't it require a populated resource= ? =20 > > Which is what I'm saying is the issue here i.e. we don't have one. >=20 > Sorry, I meant of_iomap(). I think it's only for historic reaons > that we have both. Probably of_iomap started out on powerpc with > the same intention as the sparc of_ioremap. >=20 > of_iomap does not require a resource, just an index. Ah, this sounds like a better solution. I'll have a play, thanks. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html