From: Ioan Nicu <ioan.nicu.ext@nsn.com>
To: ext Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Alexander Sverdlin <alexander.sverdlin@nsn.com>,
ext Rob Herring <robherring2@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Grant Likely <grant.likely@secretlab.ca>,
Stephen Warren <swarren@wwwdotorg.org>,
Matt Porter <matt.porter@linaro.org>,
Koen Kooi <koen@dominion.thruhere.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alison Chaiken <Alison_Chaiken@mentor.com>,
Dinh Nguyen <dinh.linux@gmail.com>, Jan Lubbe <jluebbe@lasnet.de>,
Michael Stickel <ms@mycable.de>,
Dirk Behme <dirk.behme@gmail.com>,
Alan Tull <delicious.quinoa@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Michael Bohan <mbohan@codeaurora.org>,
Michal Simek <monstr@monstr.eu>,
Matt Ranostay <mranostay@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Wolfram Sang <wsa@the-dreams.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pete Popov <pete.popov@konsulko.com>,
Dan Malek <dan.malek@konsulko.com>,
Georgi Vlaev <georgi.vlaev@konsulko.com>
Subject: Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes
Date: Tue, 24 Jun 2014 20:31:55 +0200 [thread overview]
Message-ID: <20140624183155.GA12606@heimdall> (raw)
In-Reply-To: <20140624182247.GA12169@heimdall>
Hi,
On Tue, Jun 24, 2014 at 08:23:08PM +0200, Ioan Nicu wrote:
> Hi Pantelis,
>
>
> Those are not the only users, and drivers/ is not the only place to look
> for them. For example in sound/ppc/tumbler.c:
>
> [...]
> paddr = of_get_property(tas_node, "i2c-address", NULL);
> if (paddr == NULL)
> paddr = of_get_property(tas_node, "reg", NULL);
> [...]
>
> This code should also use of_find_property() IMHO.
>
One correction. This example is wrong for our discussion, so ignore it.
But I was showing it just to highlight that there may be other wrong uses
which don't fit the pattern you specified.
I guess that the only way to catch them all is using your patch which issues
a warning.
Regards,
Ioan.
next prev parent reply other threads:[~2014-06-24 18:31 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-22 9:40 [PATCH 0/6] OF: Fixes preparing transactions/overlays Pantelis Antoniou
2014-06-22 9:40 ` [PATCH 1/6] of: Do not free memory at of_node_release Pantelis Antoniou
2014-06-24 14:10 ` Grant Likely
2014-06-24 14:23 ` Pantelis Antoniou
2014-06-24 20:21 ` Grant Likely
2014-06-24 20:23 ` Pantelis Antoniou
2014-06-24 20:33 ` Guenter Roeck
2014-06-24 21:02 ` Pantelis Antoniou
2014-06-24 23:20 ` Guenter Roeck
2014-06-25 19:24 ` Grant Likely
2014-06-24 14:53 ` Guenter Roeck
2014-06-22 9:40 ` [PATCH 2/6] OF: Add [__]of_find_node_by_full_name Pantelis Antoniou
2014-06-23 17:58 ` Guenter Roeck
2014-06-23 18:00 ` Pantelis Antoniou
[not found] ` <4F4A55EC-744B-49CC-96FA-811C9483A43D-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-06-24 13:55 ` Grant Likely
2014-06-24 14:12 ` Grant Likely
2014-06-24 14:23 ` Pantelis Antoniou
2014-06-22 9:40 ` [PATCH 3/6] of: platform: Fix and export of_platform_device_destroy Pantelis Antoniou
2014-06-24 14:23 ` Grant Likely
2014-06-24 15:13 ` Grant Likely
2014-06-22 9:40 ` [PATCH 4/6] OF: Export a number of __of_* methods Pantelis Antoniou
2014-06-24 19:27 ` Grant Likely
2014-06-24 19:38 ` Pantelis Antoniou
2014-06-24 20:19 ` Grant Likely
2014-06-22 9:40 ` [PATCH 5/6] OF: Utility helper functions for dynamic nodes Pantelis Antoniou
[not found] ` <1403430039-15085-6-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-06-23 16:26 ` Alexander Sverdlin
2014-06-23 16:57 ` Pantelis Antoniou
2014-06-23 18:33 ` Ioan Nicu
2014-06-23 19:13 ` Pantelis Antoniou
[not found] ` <78ACBAF6-A73E-4272-8D3A-258C4B10858C-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2014-06-23 19:48 ` Guenter Roeck
2014-06-23 20:39 ` Ioan Nicu
2014-06-24 9:08 ` Pantelis Antoniou
2014-06-24 13:46 ` Rob Herring
2014-06-24 13:53 ` Alexander Sverdlin
2014-06-24 14:49 ` Rob Herring
2014-06-24 15:43 ` Alexander Sverdlin
2014-06-24 15:59 ` Pantelis Antoniou
2014-06-24 18:23 ` Ioan Nicu
2014-06-24 18:31 ` Ioan Nicu [this message]
2014-06-24 18:43 ` Pantelis Antoniou
2014-06-24 8:12 ` Alexander Sverdlin
2014-06-24 8:19 ` Pantelis Antoniou
2014-06-24 8:38 ` Alexander Sverdlin
2014-06-24 8:54 ` Pantelis Antoniou
2014-06-24 9:00 ` Alexander Sverdlin
2014-06-24 9:09 ` Pantelis Antoniou
2014-06-24 8:10 ` Alexander Sverdlin
2014-06-25 9:09 ` Grant Likely
2014-06-25 11:14 ` Grant Likely
2014-06-25 11:22 ` Pantelis Antoniou
2014-06-22 9:40 ` [PATCH 6/6] of: Introduce tree change __foo_post methods Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140624183155.GA12606@heimdall \
--to=ioan.nicu.ext@nsn.com \
--cc=Alison_Chaiken@mentor.com \
--cc=alexander.sverdlin@nsn.com \
--cc=broonie@kernel.org \
--cc=dan.malek@konsulko.com \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinh.linux@gmail.com \
--cc=dirk.behme@gmail.com \
--cc=georgi.vlaev@konsulko.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=jlbec@evilplan.org \
--cc=jluebbe@lasnet.de \
--cc=koen@dominion.thruhere.net \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt.porter@linaro.org \
--cc=mbohan@codeaurora.org \
--cc=monstr@monstr.eu \
--cc=mranostay@gmail.com \
--cc=ms@mycable.de \
--cc=pantelis.antoniou@konsulko.com \
--cc=pete.popov@konsulko.com \
--cc=robherring2@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).