From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v2 1/2] media: soc_camera: pxa_camera documentation device-tree support Date: Wed, 25 Jun 2014 11:30:42 +0100 Message-ID: <20140625103042.GB14495@leverpostej> References: <1403389307-17489-1-git-send-email-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1403389307-17489-1-git-send-email-robert.jarzmik@free.fr> Sender: linux-media-owner@vger.kernel.org To: Robert Jarzmik Cc: "g.liakhovetski@gmx.de" , "devicetree@vger.kernel.org" , "linux-media@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Sat, Jun 21, 2014 at 11:21:46PM +0100, Robert Jarzmik wrote: > Add device-tree bindings documentation for pxa_camera driver. > > Signed-off-by: Robert Jarzmik > --- > .../devicetree/bindings/media/pxa-camera.txt | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/pxa-camera.txt > > diff --git a/Documentation/devicetree/bindings/media/pxa-camera.txt b/Documentation/devicetree/bindings/media/pxa-camera.txt > new file mode 100644 > index 0000000..9835aae > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/pxa-camera.txt > @@ -0,0 +1,39 @@ > +Marvell PXA camera host interface > + > +Required properties: > + - compatible: Should be "marvell,pxa27x-qci" Is that x a wildcard? Or is 'x' part of the name of a particular unit? We prefer not to have wildcard compatible strings in DT. > + - reg: register base and size > + - interrupts: the interrupt number > + - any required generic properties defined in video-interfaces.txt > + > +Optional properties: > + - clock-frequency: host interface is driving MCLK, and MCLK rate is this rate Is MCLK an input or an output of this block? If the former, why isn't this described as a clock? > + > +Example: > + > + pxa_camera: pxa_camera@50000000 { > + compatible = "marvell,pxa27x-qci"; > + reg = <0x50000000 0x1000>; > + interrupts = <33>; > + > + clocks = <&pxa2xx_clks 24>; > + clock-names = "camera"; These weren't mentioned above. Is the clock input line really called "camera"? Mark.