From: Andy Whitcroft <apw@canonical.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Joe Perches <joe@perches.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Enable whitespace checks for DTS files
Date: Mon, 30 Jun 2014 11:11:37 +0100 [thread overview]
Message-ID: <20140630101137.GA31222@bark> (raw)
In-Reply-To: <1404122011-11409-1-git-send-email-geert+renesas@glider.be>
On Mon, Jun 30, 2014 at 11:53:31AM +0200, Geert Uytterhoeven wrote:
> When run on *.dtsi or *.dts files, the whitespace checks were skipped,
> while they are valid for DTS files. Hence stop skipping them.
>
> I ran checkpatch on all in-tree DTS files, and didn't notice any error or
> warning messages that are inappropriate for DTS files.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 010b18ef4ea0..9ae624942a84 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2137,7 +2137,7 @@ sub process {
> }
>
> # check we are in a valid source file if not then ignore this hunk
> - next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
> + next if ($realfile !~ /\.(h|c|s|S|pl|sh|dtsi|dts)$/);
I think it is this one here which lets the white space checks happen for
your new file types ...
> #line length limit
> if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
> @@ -2192,7 +2192,7 @@ sub process {
> }
>
> # check we are in a valid source file C or perl if not then ignore this hunk
> - next if ($realfile !~ /\.(h|c|pl)$/);
> + next if ($realfile !~ /\.(h|c|pl|dtsi|dts)$/);
... so I am supprised to see you also changing this one. Is there a
check below here you wanted other than those stated in the patch
commentary?
>
> # at the beginning of a line any tabs must come first and anything
> # more than 8 must use tabs.
-apw
next prev parent reply other threads:[~2014-06-30 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 9:53 [PATCH] checkpatch: Enable whitespace checks for DTS files Geert Uytterhoeven
2014-06-30 10:11 ` Andy Whitcroft [this message]
2014-06-30 11:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630101137.GA31222@bark \
--to=apw@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).