From: Mark Brown <broonie@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, galak@codeaurora.org,
zhen1.chen@samsung.com, kyungmin.park@samsung.com,
m.szyprowski@samsung.com, alsa-devel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 1/2] ASoC: samsung: Add machine driver for Odroid X2/U3
Date: Mon, 30 Jun 2014 19:46:58 +0100 [thread overview]
Message-ID: <20140630184658.GE23300@sirena.org.uk> (raw)
In-Reply-To: <1403108551-25058-2-git-send-email-s.nawrocki@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
On Wed, Jun 18, 2014 at 06:22:30PM +0200, Sylwester Nawrocki wrote:
> +struct odroidx2_drv_data odroidx2_drvdata = {
> + .dapm_widgets = odroidx2_dapm_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(odroidx2_dapm_widgets),
> +};
> +
> +struct odroidx2_drv_data odroidu3_drvdata = {
> + .dapm_widgets = odroidu3_dapm_widgets,
> + .num_dapm_widgets = ARRAY_SIZE(odroidu3_dapm_widgets),
> +};
> + ret = snd_soc_of_parse_audio_routing(card, "samsung,audio-routing");
> + if (ret < 0)
> + return ret;
Given that the widgets don't have any actions defined and the routing is
all done by DT it might be easier and more flexible to just define all
the widgets all the time and let them hang there if they're not in use,
that way you don't need multiple compatible strings. If you do that
you're then very close to being able to use simple-card...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-06-30 18:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 16:22 [PATCH V2 0/2] Sound support for Exynos4412 Odroid X2, U3 board Sylwester Nawrocki
2014-06-18 16:22 ` [PATCH V2 1/2] ASoC: samsung: Add machine driver for Odroid X2/U3 Sylwester Nawrocki
2014-06-30 18:46 ` Mark Brown [this message]
2014-07-14 11:27 ` Sylwester Nawrocki
2014-07-14 11:31 ` Mark Brown
2014-06-18 16:22 ` [PATCH V2 2/2] doc: dt bindings: Document Odroid X2/U3 audio subsystem bindings Sylwester Nawrocki
2014-06-23 9:40 ` [PATCH V2 0/2] Sound support for Exynos4412 Odroid X2, U3 board Daniel Drake
2014-06-23 16:32 ` Sylwester Nawrocki
[not found] ` <53A856AE.1030202-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-23 16:53 ` Sylwester Nawrocki
2014-06-24 8:35 ` Daniel Drake
2014-06-24 9:02 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630184658.GE23300@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@vger.kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=s.nawrocki@samsung.com \
--cc=zhen1.chen@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox