* [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused
@ 2014-06-28 21:48 Rickard Strandqvist
2014-07-01 7:07 ` Sascha Hauer
2014-07-08 8:29 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2014-06-28 21:48 UTC (permalink / raw)
To: Linus Walleij, Grant Likely
Cc: Rickard Strandqvist, Rob Herring, linux-kernel, devicetree
Removal of a struct that is never used
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/pinctrl/pinctrl-imx27.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-imx27.c b/drivers/pinctrl/pinctrl-imx27.c
index 417c992..27ae7ce 100644
--- a/drivers/pinctrl/pinctrl-imx27.c
+++ b/drivers/pinctrl/pinctrl-imx27.c
@@ -440,12 +440,6 @@ static struct of_device_id imx27_pinctrl_of_match[] = {
{ /* sentinel */ }
};
-struct imx27_pinctrl_private {
- int num_gpio_childs;
- struct platform_device **gpio_dev;
- struct mxc_gpio_platform_data *gpio_pdata;
-};
-
static int imx27_pinctrl_probe(struct platform_device *pdev)
{
return imx1_pinctrl_core_probe(pdev, &imx27_pinctrl_info);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused
2014-06-28 21:48 [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused Rickard Strandqvist
@ 2014-07-01 7:07 ` Sascha Hauer
2014-07-08 8:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2014-07-01 7:07 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Linus Walleij, Grant Likely, Rob Herring, linux-kernel,
devicetree
On Sat, Jun 28, 2014 at 11:48:40PM +0200, Rickard Strandqvist wrote:
> Removal of a struct that is never used
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
It wasn't even used on the initial commit introducing it.
Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> drivers/pinctrl/pinctrl-imx27.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-imx27.c b/drivers/pinctrl/pinctrl-imx27.c
> index 417c992..27ae7ce 100644
> --- a/drivers/pinctrl/pinctrl-imx27.c
> +++ b/drivers/pinctrl/pinctrl-imx27.c
> @@ -440,12 +440,6 @@ static struct of_device_id imx27_pinctrl_of_match[] = {
> { /* sentinel */ }
> };
>
> -struct imx27_pinctrl_private {
> - int num_gpio_childs;
> - struct platform_device **gpio_dev;
> - struct mxc_gpio_platform_data *gpio_pdata;
> -};
> -
> static int imx27_pinctrl_probe(struct platform_device *pdev)
> {
> return imx1_pinctrl_core_probe(pdev, &imx27_pinctrl_info);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused
2014-06-28 21:48 [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused Rickard Strandqvist
2014-07-01 7:07 ` Sascha Hauer
@ 2014-07-08 8:29 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2014-07-08 8:29 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Grant Likely, Rob Herring, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Alexander Shiyan
On Sat, Jun 28, 2014 at 11:48 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Removal of a struct that is never used
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Already removed in a similar patch from Alexander Shiyan, but thanks
anyway!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-08 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-28 21:48 [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused Rickard Strandqvist
2014-07-01 7:07 ` Sascha Hauer
2014-07-08 8:29 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).