devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: James Cameron <quozl-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
Cc: Bing Zhao <bzhao-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Daniel Mack <daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>,
	Andreas Fenkart
	<afenkart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-mmc <linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: mwifiex card reset
Date: Tue, 1 Jul 2014 10:41:02 +0300	[thread overview]
Message-ID: <20140701074101.GA8806@atomide.com> (raw)
In-Reply-To: <20140701070349.GN24891-kJBlkiJxCS/dtAWm4Da02A@public.gmane.org>

* James Cameron <quozl-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org> [140701 10:05]:
> On Tue, Jul 01, 2014 at 12:02:25AM -0700, Bing Zhao wrote:
> > Hi James,
> > 
> > > On Mon, Jun 30, 2014 at 11:44:29PM -0700, Bing Zhao wrote:
> > > > I may have missed something, but doesn't the MMC_POWER_OFF and
> > > > MMC_POWER_ON|UP handling in controller driver help?
> > > > Anyway the clocks/GPIOs/regulators are sort of platform dependent.
> > > > Would it be better putting it in /arch/arm/mach-xxxxx/?
> > > 
> > > Wouldn't device tree for mmc be better?
> > 
> > Yes, device tree is better for defining clocks/GPIO/regulators, etc.
> > But I guess the reset logic (making use of these definitions) cannot
> > be device tree?
> 
> I think the reset logic can exist, but does nothing unless the device
> tree definitions are present.

It might be possible to support the SDIO card specific
clocks/GPIOs/regulators the MMC bus driver. But that may not
work well in the long run as those pins are not connected to
the MMC bus at all. If we wanted to explore adding card
specific features to the MMC bus, I guess we should have:

- Card reset-gpios

- Card specific regulators on the card controlled by
  a GPIO

- External card specific regulators

- Card specific idle status pin (no idea what these pins
  do on some of the mwifiex cards though?)

And then these would have to be configured to get the
SDIO card to probe. And they should be controllable also
from user space to reset a card or to power it off.

Then if we get a device that muxes two different SDIO cards
on the same bus, then what do we do? They may both have
their own regulators and reset GPIO pins.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-07-01  7:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 14:39 mwifiex card reset Andreas Fenkart
     [not found] ` <CALtMJEBWPM+75wxM2Mp5EX_o6NWtZUJdYRCv6psbvdUn4k295w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-28  5:22   ` James Cameron
     [not found]     ` <20140628052220.GG10407-kJBlkiJxCS/dtAWm4Da02A@public.gmane.org>
2014-06-28  7:23       ` Tony Lindgren
2014-06-29  9:41         ` Andreas Fenkart
2014-06-30  6:19           ` Tony Lindgren
2014-06-30 19:30             ` Daniel Mack
     [not found]               ` <53B1BAC1.3090902-cYrQPVfZoowdnm+yROfE0A@public.gmane.org>
2014-07-01  6:44                 ` Bing Zhao
2014-07-01  6:57                   ` James Cameron
     [not found]                     ` <20140701065721.GM24891-kJBlkiJxCS/dtAWm4Da02A@public.gmane.org>
2014-07-01  7:02                       ` Bing Zhao
2014-07-01  7:03                         ` James Cameron
     [not found]                           ` <20140701070349.GN24891-kJBlkiJxCS/dtAWm4Da02A@public.gmane.org>
2014-07-01  7:41                             ` Tony Lindgren [this message]
2014-07-01 12:20                     ` Yuvaraj Cd
2014-07-01 15:09                       ` Doug Anderson
2014-07-15 13:25                         ` Andreas Fenkart
2014-07-01  7:52                   ` Daniel Mack
2014-07-01  8:44                   ` Andreas Fenkart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140701074101.GA8806@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=afenkart-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=bzhao-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    --cc=daniel-cYrQPVfZoowdnm+yROfE0A@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=quozl-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
    --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).