From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v5 03/14] clk: max77686: Add DT include for MAX77686 PMIC clock Date: Tue, 01 Jul 2014 10:30:22 -0700 Message-ID: <20140701173022.32686.28561@quantum> References: <1403806546-31122-1-git-send-email-javier.martinez@collabora.co.uk> <1403806546-31122-4-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1403806546-31122-4-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Samuel Ortiz , Mark Brown , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , Krzysztof Kozlowski , Yadwinder Singh Brar , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Javier Martinez Canillas List-Id: devicetree@vger.kernel.org Quoting Javier Martinez Canillas (2014-06-26 11:15:35) > This patch adds a dt-binding include for Maxim 77686 > PMIC clock IDs that can be to be shared between the > clk-max77686 clock driver and DeviceTree source files. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski Looks good to me. Regards, Mike > --- > > Changes since v4: None > > Changes since v3: None > > drivers/clk/clk-max77686.c | 7 +------ > include/dt-bindings/clock/maxim,max77686.h | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 6 deletions(-) > create mode 100644 include/dt-bindings/clock/maxim,max77686.h > > diff --git a/drivers/clk/clk-max77686.c b/drivers/clk/clk-max77686.c > index 3d7e8dd..185b611 100644 > --- a/drivers/clk/clk-max77686.c > +++ b/drivers/clk/clk-max77686.c > @@ -30,12 +30,7 @@ > #include > #include > > -enum { > - MAX77686_CLK_AP = 0, > - MAX77686_CLK_CP, > - MAX77686_CLK_PMIC, > - MAX77686_CLKS_NUM, > -}; > +#include > > struct max77686_clk { > struct max77686_dev *iodev; > diff --git a/include/dt-bindings/clock/maxim,max77686.h b/include/dt-bindings/clock/maxim,max77686.h > new file mode 100644 > index 0000000..7b28b09 > --- /dev/null > +++ b/include/dt-bindings/clock/maxim,max77686.h > @@ -0,0 +1,23 @@ > +/* > + * Copyright (C) 2014 Google, Inc > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * Device Tree binding constants clocks for the Maxim 77686 PMIC. > + */ > + > +#ifndef _DT_BINDINGS_CLOCK_MAXIM_MAX77686_CLOCK_H > +#define _DT_BINDINGS_CLOCK_MAXIM_MAX77686_CLOCK_H > + > +/* Fixed rate clocks. */ > + > +#define MAX77686_CLK_AP 0 > +#define MAX77686_CLK_CP 1 > +#define MAX77686_CLK_PMIC 2 > + > +/* Total number of clocks. */ > +#define MAX77686_CLKS_NUM (MAX77686_CLK_PMIC + 1) > + > +#endif /* _DT_BINDINGS_CLOCK_MAXIM_MAX77686_CLOCK_H */ > -- > 2.0.0.rc2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html