* [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document [not found] ` <1404198121-22989-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2014-07-01 7:02 ` Krzysztof Kozlowski [not found] ` <1404198121-22989-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2014-07-01 7:02 UTC (permalink / raw) To: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski, Tomasz Figa, devicetree-u79uwXL29TY76Z2rM5mHXA Add document describing device tree bindings for MAX14577 MFD drivers: MFD core, extcon, regulator and charger. Both MAX14577 and MAX77836 chipsets are documented. Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Cc: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> --- Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ 1 file changed, 152 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt new file mode 100644 index 000000000000..b235250a7b41 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/max14577.txt @@ -0,0 +1,152 @@ +Maxim MAX14577/77836 Multi-Function Device + +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ +Battery Charger and SFOUT LDO output for powering USB devices. It is +interfaced to host controller using I2C. + +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. + + +Required properties: +- compatible : Must be "maxim,max14577" or "maxim,max77836". +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) +- interrupts : IRQ line for the chip. +- interrupt-parent : The parent interrupt controller. + + +Required nodes: + - charger : + Node for configuring the charger driver. + Required properties: + - compatible : "maxim,max14577-charger" + or "maxim,max77836-charger" + - maxim,fast-charge-timer : Timer in hours to trigger the + INT3/MBCCHGERR interrupt; Valid values: + - 5, 6 or 7 (hours), + - 0 to disable. + - maxim,fast-charge-uamp : Current in uA for Fast Charge; + Valid values: + - for max14577: 90000 - 950000; + - for max77836: 45000 - 475000; + - maxim,eoc-uamp : Current in uA for End-Of-Charge mode; + Valid values: + - for max14577: 50000 - 200000; + - for max77836: 5000 - 100000; + - maxim,ovp-uvolt : OverVoltage Protection Threshold in uV; + In an overvoltage condition, INT asserts and charging + stops. Valid values: + - 6000000, 6500000, 7000000, 7500000; + - maxim,constant-uvolt : Battery Constant Voltage in uV; + Valid values: + - 4000000 - 4280000 (step by 20000); + - 4350000; + + +Optional nodes: +- max14577-muic/max77836-muic : + Node used only by extcon consumers. + Required properties: + - compatible : "maxim,max14577-muic" or "maxim,max77836-muic" + +- regulators : + Required properties: + - compatible : "maxim,max14577-regulator" + or "maxim,max77836-regulator" + + May contain a sub-node per regulator from the list below. Each + sub-node should contain the constraints and initialization information + for that regulator. See regulator.txt for a description of standard + properties for these sub-nodes. + + List of valid regulator names: + - for max14577: CHARGER, SAFEOUT. + - for max77836: CHARGER, SAFEOUT, LDO1, LDO2. + + The SAFEOUT is a fixed voltage regulator so there is no need to specify + voltages for it. + + +Example: + +#include <dt-bindings/interrupt-controller/irq.h> + +max14577@25 { + compatible = "maxim,max14577"; + reg = <0x25>; + interrupt-parent = <&gpx1>; + interrupts = <5 IRQ_TYPE_NONE>; + + muic: max14577-muic { + compatible = "maxim,max14577-muic"; + }; + + regulators { + compatible = "maxim,max14577-regulator"; + + SAFEOUT { + regulator-name = "SAFEOUT"; + }; + CHARGER { + regulator-name = "CHARGER"; + regulator-min-microamp = <90000>; + regulator-max-microamp = <950000>; + regulator-boot-on; + }; + }; + + charger { + compatible = "maxim,max14577-charger"; + + maxim,fast-charge-timer = <6>; + maxim,constant-uvolt = <4350000>; + maxim,fast-charge-uamp = <450000>; + maxim,eoc-uamp = <50000>; + maxim,ovp-uvolt = <6500000>; + }; +}; + + +max77836@25 { + compatible = "maxim,max77836"; + reg = <0x25>; + interrupt-parent = <&gpx1>; + interrupts = <5 IRQ_TYPE_NONE>; + + muic: max77836-muic { + compatible = "maxim,max77836-muic"; + }; + + regulators { + compatible = "maxim,max77836-regulator"; + + SAFEOUT { + regulator-name = "SAFEOUT"; + }; + CHARGER { + regulator-name = "CHARGER"; + regulator-min-microamp = <90000>; + regulator-max-microamp = <950000>; + regulator-boot-on; + }; + LDO1 { + regulator-name = "LDO1"; + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <2700000>; + }; + LDO2 { + regulator-name = "LDO2"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <3950000>; + }; + }; + + charger { + compatible = "maxim,max77836-charger"; + + maxim,fast-charge-timer = <6>; + maxim,constant-uvolt = <4350000>; + maxim,fast-charge-uamp = <225000>; + maxim,eoc-uamp = <7500>; + maxim,ovp-uvolt = <6500000>; + }; +}; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1404198121-22989-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document [not found] ` <1404198121-22989-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2014-07-03 11:32 ` Mark Rutland 2014-07-03 11:44 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Mark Rutland @ 2014-07-03 11:32 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring, Pawel Moll, Ian Campbell, Kumar Gala, Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Tomasz Figa, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hi, On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote: > Add document describing device tree bindings for MAX14577 MFD > drivers: MFD core, extcon, regulator and charger. > > Both MAX14577 and MAX77836 chipsets are documented. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Cc: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ > 1 file changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt > new file mode 100644 > index 000000000000..b235250a7b41 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt > @@ -0,0 +1,152 @@ > +Maxim MAX14577/77836 Multi-Function Device > + > +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ > +Battery Charger and SFOUT LDO output for powering USB devices. It is > +interfaced to host controller using I2C. > + > +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. > + > + > +Required properties: > +- compatible : Must be "maxim,max14577" or "maxim,max77836". > +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) > +- interrupts : IRQ line for the chip. > +- interrupt-parent : The parent interrupt controller. > + > + > +Required nodes: > + - charger : > + Node for configuring the charger driver. > + Required properties: > + - compatible : "maxim,max14577-charger" > + or "maxim,max77836-charger" > + - maxim,fast-charge-timer : Timer in hours to trigger the > + INT3/MBCCHGERR interrupt; Valid values: > + - 5, 6 or 7 (hours), > + - 0 to disable. I'm not sure I follow what this is any why it should be in the DT. Could you explain what this is used for? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document 2014-07-03 11:32 ` Mark Rutland @ 2014-07-03 11:44 ` Krzysztof Kozlowski 2014-07-04 8:07 ` Mark Rutland 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2014-07-03 11:44 UTC (permalink / raw) To: Mark Rutland Cc: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring, Pawel Moll, Ian Campbell, Kumar Gala, Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Tomasz Figa, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On czw, 2014-07-03 at 12:32 +0100, Mark Rutland wrote: > Hi, > > On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote: > > Add document describing device tree bindings for MAX14577 MFD > > drivers: MFD core, extcon, regulator and charger. > > > > Both MAX14577 and MAX77836 chipsets are documented. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > Cc: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > > Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > > Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > > Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > > Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > --- > > Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ > > 1 file changed, 152 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt > > new file mode 100644 > > index 000000000000..b235250a7b41 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt > > @@ -0,0 +1,152 @@ > > +Maxim MAX14577/77836 Multi-Function Device > > + > > +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ > > +Battery Charger and SFOUT LDO output for powering USB devices. It is > > +interfaced to host controller using I2C. > > + > > +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. > > + > > + > > +Required properties: > > +- compatible : Must be "maxim,max14577" or "maxim,max77836". > > +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) > > +- interrupts : IRQ line for the chip. > > +- interrupt-parent : The parent interrupt controller. > > + > > + > > +Required nodes: > > + - charger : > > + Node for configuring the charger driver. > > + Required properties: > > + - compatible : "maxim,max14577-charger" > > + or "maxim,max77836-charger" > > + - maxim,fast-charge-timer : Timer in hours to trigger the > > + INT3/MBCCHGERR interrupt; Valid values: > > + - 5, 6 or 7 (hours), > > + - 0 to disable. > > I'm not sure I follow what this is any why it should be in the DT. > > Could you explain what this is used for? Hi, These are settings for max14577 battery charger. Actually this particular setting does not look like board-specific but other (like battery voltage) do. The timer above is used by device to stop charging and to trigger interrupt. Best regards, Krzysztof > > Thanks, > Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document 2014-07-03 11:44 ` Krzysztof Kozlowski @ 2014-07-04 8:07 ` Mark Rutland 2014-07-04 8:13 ` Krzysztof Kozlowski 0 siblings, 1 reply; 6+ messages in thread From: Mark Rutland @ 2014-07-04 8:07 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring, Pawel Moll, Ian Campbell, Kumar Gala, Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Tomasz Figa, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Jul 03, 2014 at 12:44:34PM +0100, Krzysztof Kozlowski wrote: > On czw, 2014-07-03 at 12:32 +0100, Mark Rutland wrote: > > Hi, > > > > On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote: > > > Add document describing device tree bindings for MAX14577 MFD > > > drivers: MFD core, extcon, regulator and charger. > > > > > > Both MAX14577 and MAX77836 chipsets are documented. > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > Cc: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > > Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > > > Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > > > Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > > > Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > > > Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > --- > > > Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ > > > 1 file changed, 152 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt > > > new file mode 100644 > > > index 000000000000..b235250a7b41 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt > > > @@ -0,0 +1,152 @@ > > > +Maxim MAX14577/77836 Multi-Function Device > > > + > > > +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ > > > +Battery Charger and SFOUT LDO output for powering USB devices. It is > > > +interfaced to host controller using I2C. > > > + > > > +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. > > > + > > > + > > > +Required properties: > > > +- compatible : Must be "maxim,max14577" or "maxim,max77836". > > > +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) > > > +- interrupts : IRQ line for the chip. > > > +- interrupt-parent : The parent interrupt controller. > > > + > > > + > > > +Required nodes: > > > + - charger : > > > + Node for configuring the charger driver. > > > + Required properties: > > > + - compatible : "maxim,max14577-charger" > > > + or "maxim,max77836-charger" > > > + - maxim,fast-charge-timer : Timer in hours to trigger the > > > + INT3/MBCCHGERR interrupt; Valid values: > > > + - 5, 6 or 7 (hours), > > > + - 0 to disable. > > > > I'm not sure I follow what this is any why it should be in the DT. > > > > Could you explain what this is used for? > > Hi, > > These are settings for max14577 battery charger. Actually this > particular setting does not look like board-specific but other (like > battery voltage) do. > > The timer above is used by device to stop charging and to trigger > interrupt. Ok. What I don't get is why this should be in the DT, it sounds like a configuration option that would better be set at run time. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document 2014-07-04 8:07 ` Mark Rutland @ 2014-07-04 8:13 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2014-07-04 8:13 UTC (permalink / raw) To: Mark Rutland Cc: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring, Pawel Moll, Ian Campbell, Kumar Gala, Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Tomasz Figa, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On pią, 2014-07-04 at 09:07 +0100, Mark Rutland wrote: > On Thu, Jul 03, 2014 at 12:44:34PM +0100, Krzysztof Kozlowski wrote: > > On czw, 2014-07-03 at 12:32 +0100, Mark Rutland wrote: > > > Hi, > > > > > > On Tue, Jul 01, 2014 at 08:02:00AM +0100, Krzysztof Kozlowski wrote: > > > > Add document describing device tree bindings for MAX14577 MFD > > > > drivers: MFD core, extcon, regulator and charger. > > > > > > > > Both MAX14577 and MAX77836 chipsets are documented. > > > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > > Cc: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > > > Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > > > > Cc: Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org> > > > > Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> > > > > Cc: Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org> > > > > Cc: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > > > > Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> > > > > --- > > > > Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ > > > > 1 file changed, 152 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt > > > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt > > > > new file mode 100644 > > > > index 000000000000..b235250a7b41 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/mfd/max14577.txt > > > > @@ -0,0 +1,152 @@ > > > > +Maxim MAX14577/77836 Multi-Function Device > > > > + > > > > +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ > > > > +Battery Charger and SFOUT LDO output for powering USB devices. It is > > > > +interfaced to host controller using I2C. > > > > + > > > > +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. > > > > + > > > > + > > > > +Required properties: > > > > +- compatible : Must be "maxim,max14577" or "maxim,max77836". > > > > +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) > > > > +- interrupts : IRQ line for the chip. > > > > +- interrupt-parent : The parent interrupt controller. > > > > + > > > > + > > > > +Required nodes: > > > > + - charger : > > > > + Node for configuring the charger driver. > > > > + Required properties: > > > > + - compatible : "maxim,max14577-charger" > > > > + or "maxim,max77836-charger" > > > > + - maxim,fast-charge-timer : Timer in hours to trigger the > > > > + INT3/MBCCHGERR interrupt; Valid values: > > > > + - 5, 6 or 7 (hours), > > > > + - 0 to disable. > > > > > > I'm not sure I follow what this is any why it should be in the DT. > > > > > > Could you explain what this is used for? > > > > Hi, > > > > These are settings for max14577 battery charger. Actually this > > particular setting does not look like board-specific but other (like > > battery voltage) do. > > > > The timer above is used by device to stop charging and to trigger > > interrupt. > > Ok. What I don't get is why this should be in the DT, it sounds like a > configuration option that would better be set at run time. I understand. I'll add this as sysfs entry and re-spin with version 3 of patchset. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [RESEND PATCH 0/5] charger/mfd: max14577: Part 2 of adding support for MAX77836
@ 2014-05-26 7:47 Krzysztof Kozlowski
2014-05-26 7:47 ` [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2014-05-26 7:47 UTC (permalink / raw)
To: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel
Cc: Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring,
Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Tomasz Figa,
devicetree, Kyungmin Park, Marek Szyprowski,
Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski
Dear Dmitry, David,
This is resend of second part of patches adding support for MAX77836
device to the max14577 drivers.
These patches are hanging on the lists for some time. Could you
look at them and give me acks or any comment what have to be fixed?
It is still before 3.16 merge window so your acks would be appreciated.
If it is possible I would like to push the patches through Lee Jones'
MFD tree (I already have other necessary acks).
I need acks or reviews from power supply subsystem maintainers for
patches:
- 1/5: charger: max14577: Add support for MAX77836 charger
- 3/5: charger: max14577: Configure battery-dependent settings from DTS
- 4/5: power: max17040: Add ID for MAX77836 Fuel Gauge block
These patches were published for the first time around February 2014.
Could you look at them?
Below is original cover letter.
Best regards,
Krzysztof Kozlowski
Cover letter
============
This is second part of patches adding support for MAX77836 device
to the max14577 drivers.
The first part [1] was applied by Lee Jones [2][3] and this patchset
*depends* on it.
This patchset changes the max14577 charger and regulator drivers
and documents Device Tree bindings.
The patches 1 to 3 depends on each other so they should be pulled at once.
Patches 4, 5 and 6 can be applied independently. However still the
smoothest way to apply this would be through one tree after obtaining
necessary acks from maintainers.
Changes since v4 (for this second part only)
============================================
1. Updated Kconfig entries mentioning MAX77836.
2. Added patch 5/6 (regulator: max14577: Implement SUSPEND mode for
MAX77836 LDO-s)
3. Charger: Require a charger subnode in DTS with charger settings.
Previously the charger driver didn't use any properties from DTS.
Now it needs a subnode with settings because it supports different
devices with different charging characteristics.
4. Rebased on 3.15-rc2.
Changes since v3
================
1. Applied minor fixes (pointed by Lee Jones).
2. Added one ACK (Lee Jones) and Review-by (Tomasz Figa).
3. Patch 14/charger: Minor change in parsing EOC value from DTS.
4. Rebased on next-20140224.
Changes since v2
================
1. Added ACK-s.
2. Applied minor checkpatch fixes (pointed by Lee Jones).
3. Rebased on next-20140217.
Changes since v1
================
1. Added ACK-s, reviews and tested-by tags.
2. Removed applied patches (they were merged to the linux-next tree).
3. Applied comments from review (Lee Jones) to 5/15 (detection of device type)
and 8/15 (add max77836 support to max14577).
4. Rebased on next tree.
5. Added patch 13 and 14 (pointed by Jenny Tc):
- regulator/mfd: max14577: Export symbols for calculating charger current
- charger: max14577: Configure battery-dependent settings from DTS
6. Updated bindings documentation with new charger bindings.
References
==========
[1] http://thread.gmane.org/gmane.linux.kernel/1682503
[2] http://www.spinics.net/lists/kernel/msg1728274.html
[3] https://git.kernel.org/cgit/linux/kernel/git/lee/mfd.git/log/?h=ib-mfd-extcon-3.16
Previous, full v4 patchset can be found here:
http://thread.gmane.org/gmane.linux.kernel/1654267
Krzysztof Kozlowski (5):
charger: max14577: Add support for MAX77836 charger
regulator/mfd: max14577: Export symbols for calculating charger
current
charger: max14577: Configure battery-dependent settings from DTS
power: max17040: Add ID for MAX77836 Fuel Gauge block
devicetree: mfd: max14577: Add device tree bindings document
Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++
drivers/mfd/max14577.c | 100 ++++++-
drivers/power/Kconfig | 4 +-
drivers/power/max14577_charger.c | 291 ++++++++++++++++++---
drivers/power/max17040_battery.c | 1 +
drivers/regulator/max14577.c | 80 +-----
include/linux/mfd/max14577-private.h | 92 +++++--
include/linux/mfd/max14577.h | 31 +++
8 files changed, 614 insertions(+), 137 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document 2014-05-26 7:47 [RESEND PATCH 0/5] charger/mfd: max14577: Part 2 of adding support for MAX77836 Krzysztof Kozlowski @ 2014-05-26 7:47 ` Krzysztof Kozlowski 0 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2014-05-26 7:47 UTC (permalink / raw) To: Dmitry Eremin-Solenikov, David Woodhouse, linux-kernel Cc: Samuel Ortiz, Lee Jones, Liam Girdwood, Mark Brown, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Tomasz Figa, devicetree, Kyungmin Park, Marek Szyprowski, Bartlomiej Zolnierkiewicz, Krzysztof Kozlowski Add document describing device tree bindings for MAX14577 MFD drivers: MFD core, extcon, regulator and charger. Both MAX14577 and MAX77836 chipsets are documented. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Tomasz Figa <t.figa@samsung.com> Cc: devicetree@vger.kernel.org Cc: Rob Herring <robh+dt@kernel.org> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk> Cc: Kumar Gala <galak@codeaurora.org> Reviewed-by: Tomasz Figa <t.figa@samsung.com> --- Documentation/devicetree/bindings/mfd/max14577.txt | 152 +++++++++++++++++++++ 1 file changed, 152 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/max14577.txt diff --git a/Documentation/devicetree/bindings/mfd/max14577.txt b/Documentation/devicetree/bindings/mfd/max14577.txt new file mode 100644 index 000000000000..b235250a7b41 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/max14577.txt @@ -0,0 +1,152 @@ +Maxim MAX14577/77836 Multi-Function Device + +MAX14577 is a Multi-Function Device with Micro-USB Interface Circuit, Li+ +Battery Charger and SFOUT LDO output for powering USB devices. It is +interfaced to host controller using I2C. + +MAX77836 additionally contains PMIC (with two LDO regulators) and Fuel Gauge. + + +Required properties: +- compatible : Must be "maxim,max14577" or "maxim,max77836". +- reg : I2C slave address for the max14577 chip (0x25 for max14577/max77836) +- interrupts : IRQ line for the chip. +- interrupt-parent : The parent interrupt controller. + + +Required nodes: + - charger : + Node for configuring the charger driver. + Required properties: + - compatible : "maxim,max14577-charger" + or "maxim,max77836-charger" + - maxim,fast-charge-timer : Timer in hours to trigger the + INT3/MBCCHGERR interrupt; Valid values: + - 5, 6 or 7 (hours), + - 0 to disable. + - maxim,fast-charge-uamp : Current in uA for Fast Charge; + Valid values: + - for max14577: 90000 - 950000; + - for max77836: 45000 - 475000; + - maxim,eoc-uamp : Current in uA for End-Of-Charge mode; + Valid values: + - for max14577: 50000 - 200000; + - for max77836: 5000 - 100000; + - maxim,ovp-uvolt : OverVoltage Protection Threshold in uV; + In an overvoltage condition, INT asserts and charging + stops. Valid values: + - 6000000, 6500000, 7000000, 7500000; + - maxim,constant-uvolt : Battery Constant Voltage in uV; + Valid values: + - 4000000 - 4280000 (step by 20000); + - 4350000; + + +Optional nodes: +- max14577-muic/max77836-muic : + Node used only by extcon consumers. + Required properties: + - compatible : "maxim,max14577-muic" or "maxim,max77836-muic" + +- regulators : + Required properties: + - compatible : "maxim,max14577-regulator" + or "maxim,max77836-regulator" + + May contain a sub-node per regulator from the list below. Each + sub-node should contain the constraints and initialization information + for that regulator. See regulator.txt for a description of standard + properties for these sub-nodes. + + List of valid regulator names: + - for max14577: CHARGER, SAFEOUT. + - for max77836: CHARGER, SAFEOUT, LDO1, LDO2. + + The SAFEOUT is a fixed voltage regulator so there is no need to specify + voltages for it. + + +Example: + +#include <dt-bindings/interrupt-controller/irq.h> + +max14577@25 { + compatible = "maxim,max14577"; + reg = <0x25>; + interrupt-parent = <&gpx1>; + interrupts = <5 IRQ_TYPE_NONE>; + + muic: max14577-muic { + compatible = "maxim,max14577-muic"; + }; + + regulators { + compatible = "maxim,max14577-regulator"; + + SAFEOUT { + regulator-name = "SAFEOUT"; + }; + CHARGER { + regulator-name = "CHARGER"; + regulator-min-microamp = <90000>; + regulator-max-microamp = <950000>; + regulator-boot-on; + }; + }; + + charger { + compatible = "maxim,max14577-charger"; + + maxim,fast-charge-timer = <6>; + maxim,constant-uvolt = <4350000>; + maxim,fast-charge-uamp = <450000>; + maxim,eoc-uamp = <50000>; + maxim,ovp-uvolt = <6500000>; + }; +}; + + +max77836@25 { + compatible = "maxim,max77836"; + reg = <0x25>; + interrupt-parent = <&gpx1>; + interrupts = <5 IRQ_TYPE_NONE>; + + muic: max77836-muic { + compatible = "maxim,max77836-muic"; + }; + + regulators { + compatible = "maxim,max77836-regulator"; + + SAFEOUT { + regulator-name = "SAFEOUT"; + }; + CHARGER { + regulator-name = "CHARGER"; + regulator-min-microamp = <90000>; + regulator-max-microamp = <950000>; + regulator-boot-on; + }; + LDO1 { + regulator-name = "LDO1"; + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <2700000>; + }; + LDO2 { + regulator-name = "LDO2"; + regulator-min-microvolt = <800000>; + regulator-max-microvolt = <3950000>; + }; + }; + + charger { + compatible = "maxim,max77836-charger"; + + maxim,fast-charge-timer = <6>; + maxim,constant-uvolt = <4350000>; + maxim,fast-charge-uamp = <225000>; + maxim,eoc-uamp = <7500>; + maxim,ovp-uvolt = <6500000>; + }; +}; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-04 8:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1404198121-22989-1-git-send-email-k.kozlowski@samsung.com>
[not found] ` <1404198121-22989-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-01 7:02 ` [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
[not found] ` <1404198121-22989-6-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-07-03 11:32 ` Mark Rutland
2014-07-03 11:44 ` Krzysztof Kozlowski
2014-07-04 8:07 ` Mark Rutland
2014-07-04 8:13 ` Krzysztof Kozlowski
2014-05-26 7:47 [RESEND PATCH 0/5] charger/mfd: max14577: Part 2 of adding support for MAX77836 Krzysztof Kozlowski
2014-05-26 7:47 ` [RESEND PATCH 5/5] devicetree: mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).