From: Mark Rutland <mark.rutland@arm.com>
To: Daniel Jeong <gshark.jeong@gmail.com>
Cc: Jingoo Han <jg1.han@samsung.com>, Bryan Wu <cooloney@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Daniel Jeong <daniel.jeong@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [RFC v4 2/2] backlight: device tree: add new tps611xx backlight binding
Date: Fri, 4 Jul 2014 17:31:19 +0100 [thread overview]
Message-ID: <20140704163119.GB7106@leverpostej> (raw)
In-Reply-To: <CAPqQCJUYqgireOiqK9DLpSAkw_4DdmKD+G7bXxVxf=bb0nTj6Q@mail.gmail.com>
> > +- rfa-enable: enable request for acknowledge.
> > + If RFA is enabled, the data byte includes the RFA bit and device will
> wait
> > + and check acknowledge from device.
>
> You didn't answer my question as to why this should be in the DT.
>
>
> According to the RFA enable, the easy scale pin works differently.
> This value should be set before the first data transfer.
Sure, things works differently if this is set. That I understood.
What I haven't heard is a rationale as to why this configuration option
shuold be in the DT.
Can I enable this on all implementations, or not?
When would I enable this and when would I not?
The property reads like a switch to turn a feature on, rather than the
description of the presence of a feature.
Mark.
next prev parent reply other threads:[~2014-07-04 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 6:01 [RFC v4 0/2] backlight: add new tps611xx backlight driver Daniel Jeong
2014-07-03 6:01 ` [RFC v4 1/2] " Daniel Jeong
2014-07-03 6:01 ` [RFC v4 2/2] backlight: device tree: add new tps611xx backlight binding Daniel Jeong
[not found] ` <1404367277-12003-3-git-send-email-gshark.jeong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-03 9:04 ` Mark Rutland
2014-07-04 2:10 ` Daniel Jeong
2014-07-04 16:31 ` Mark Rutland [this message]
2014-07-07 1:19 ` Daniel Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140704163119.GB7106@leverpostej \
--to=mark.rutland@arm.com \
--cc=cooloney@gmail.com \
--cc=daniel.jeong@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gshark.jeong@gmail.com \
--cc=jg1.han@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).