devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Keerthy <j-keerthy@ti.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, mark.rutland@arm.com,
	galak@codeaurora.org, robh+dt@kernel.org, linux@arm.linux.org.uk,
	balbi@ti.com, tony@atomide.com, kishon@ti.com,
	broonie@kernel.org
Subject: Re: [PATCH v2 6/7] regulator: tps65218: Add get_voltage ops for dcdc5 and dcdc6
Date: Tue, 8 Jul 2014 08:39:12 -0500	[thread overview]
Message-ID: <20140708133912.GH25811@saruman.home> (raw)
In-Reply-To: <1404814597-4404-7-git-send-email-j-keerthy@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

On Tue, Jul 08, 2014 at 03:46:36PM +0530, Keerthy wrote:
> Add get_voltage ops for dcdc5 and dcdc6. Both dcdc5 and 6 are fixed regulators
> and hence return min_uV (or max_uV).
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  drivers/regulator/tps65218-regulator.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
> index 9effe48..700c652 100644
> --- a/drivers/regulator/tps65218-regulator.c
> +++ b/drivers/regulator/tps65218-regulator.c
> @@ -151,6 +151,14 @@ static int tps65218_pmic_disable(struct regulator_dev *dev)
>  				   dev->desc->enable_mask, TPS65218_PROTECT_L1);
>  }
>  
> +static int tps65218_pmic_dcdc56_get_voltage(struct regulator_dev *dev)
> +{
> +	struct tps65218 *tps = rdev_get_drvdata(dev);
> +	unsigned int rid = rdev_get_id(dev);
> +
> +	return tps->info[rid]->min_uV;
> +}
> +
>  /* Operations permitted on DCDC1, DCDC2 */
>  static struct regulator_ops tps65218_dcdc12_ops = {
>  	.is_enabled		= regulator_is_enabled_regmap,
> @@ -179,6 +187,7 @@ static struct regulator_ops tps65218_dcdc56_pmic_ops = {
>  	.is_enabled		= regulator_is_enabled_regmap,
>  	.enable			= tps65218_pmic_enable,
>  	.disable		= tps65218_pmic_disable,
> +	.get_voltage		= tps65218_pmic_dcdc56_get_voltage,
>  };
>  
>  static const struct regulator_desc regulators[] = {
> -- 
> 1.7.9.5
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2014-07-08 13:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 10:16 [PATCH v2 0/7] ARM: dts: AM43x: Add devcice tree nodes Keerthy
2014-07-08 10:16 ` [PATCH v2 1/7] mfd: Add DT bindings for tps65218 PMIC Keerthy
2014-07-08 13:37   ` Felipe Balbi
2014-07-08 10:16 ` [PATCH v2 2/7] regulator: Add DT bindings for tps65218 PMIC regulators Keerthy
     [not found]   ` <1404814597-4404-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2014-07-08 13:37     ` Felipe Balbi
2014-07-08 10:16 ` [PATCH v2 3/7] ARM: dts: AM43x: Add TPS65218 device tree nodes Keerthy
2014-07-08 13:38   ` Felipe Balbi
2014-07-08 10:16 ` [PATCH v2 4/7] ARM: dts: AM437x: Fix i2c nodes indentation Keerthy
2014-07-08 13:38   ` Felipe Balbi
2014-07-08 10:16 ` [PATCH v2 5/7] ARM: dts: AM437x: Add TPS65218 device tree nodes Keerthy
2014-07-08 13:39   ` Felipe Balbi
2014-07-08 10:16 ` [PATCH v2 6/7] regulator: tps65218: Add get_voltage ops for dcdc5 and dcdc6 Keerthy
2014-07-08 13:39   ` Felipe Balbi [this message]
2014-07-08 14:11   ` Mark Brown
     [not found]     ` <20140708141126.GW30458-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-07-09  3:40       ` Keerthy
2014-07-08 10:16 ` [PATCH v2 7/7] ARM: configs: omap2plus_defconfig: enable TPS65218 configs Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140708133912.GH25811@saruman.home \
    --to=balbi@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=j-keerthy@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).