From: Tony Lindgren <tony@atomide.com>
To: Keerthy <a0393675@ti.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>,
paul@pwsan.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, rnayak@ti.com,
devicetree@vger.kernel.org, nm@ti.com, j-keerthy@ti.com,
nsekhar@ti.com
Subject: Re: [PATCH V2 2/2] ARM: dts: DRA7: Add node for RTC
Date: Wed, 9 Jul 2014 04:00:51 -0700 [thread overview]
Message-ID: <20140709110051.GQ28884@atomide.com> (raw)
In-Reply-To: <53BD1FC3.6050500@ti.com>
* Keerthy <a0393675@ti.com> [140709 03:59]:
> On Wednesday 09 July 2014 04:20 PM, Tony Lindgren wrote:
> >* Keerthy <a0393675@ti.com> [140709 03:39]:
> >>On Wednesday 09 July 2014 03:39 PM, Tony Lindgren wrote:
> >>>* Keerthy <a0393675@ti.com> [140709 02:36]:
> >>>>On Wednesday 09 July 2014 02:42 PM, Tony Lindgren wrote:
> >>>>>* Lokesh Vutla <lokeshvutla@ti.com> [140709 01:37]:
> >>>>>>--- a/arch/arm/boot/dts/dra7-evm.dts
> >>>>>>+++ b/arch/arm/boot/dts/dra7-evm.dts
> >>>>>>@@ -249,6 +249,7 @@
> >>>>>> regulator-min-microvolt = <1050000>;
> >>>>>> regulator-max-microvolt = <1050000>;
> >>>>>> regulator-boot-on;
> >>>>>>+ regulator-always-on;
> >>>>>> };
> >>>>>Is this regulator really always on?
> >>>>This feeds on to RTC which is a free running clock. So i guess always on is
> >>>>justified no?
> >>>Well the dts entries should describe the hardware. If the
> >>>regulator can be enabled and disabled, we should not claim it's
> >>>always on.
> >> From the PMIC perspective every regulator can be enabled and
> >>disabled. From a Board perspective there are some which need
> >>to be always on. For Ex: SMPS123 which feeds on to the MPU.
> >Right, and we already have regulator-boot-on for those. Or are
> >you seeing some issue with that?
> regulator-boot-on describes that at boot a particular regulator is on.
> It does not guarantee that it will be on for the rest of the time. The
> regulator framework can go ahead and disable it if no one has requested
> for it. In case of RTC we do not want that to happen.
That's a bug in the RTC driver then. The driver should request a
regulator if it's specified.
Regards,
Tony
next prev parent reply other threads:[~2014-07-09 11:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.DEB.2.02.1407060031120.23762@utopia.booyaka.com>
2014-07-09 8:35 ` [PATCH V2 0/2] ARM: DRA7: Add RTC hwmod and dt entries Lokesh Vutla
2014-07-09 8:35 ` [PATCH V2 1/2] ARM: DRA7: hwmod: Add data for RTC Lokesh Vutla
2014-07-22 10:19 ` Lokesh Vutla
2014-07-22 19:19 ` Paul Walmsley
2014-07-09 8:35 ` [PATCH V2 2/2] ARM: dts: DRA7: Add node " Lokesh Vutla
2014-07-09 9:12 ` Tony Lindgren
2014-07-09 9:32 ` Keerthy
2014-07-09 10:09 ` Tony Lindgren
2014-07-09 10:35 ` Keerthy
2014-07-09 10:50 ` Tony Lindgren
2014-07-09 10:56 ` Keerthy
2014-07-09 11:00 ` Tony Lindgren [this message]
2014-07-09 11:06 ` Keerthy
2014-07-14 14:45 ` Lokesh Vutla
2014-07-14 16:23 ` Tony Lindgren
2014-07-15 3:57 ` Keerthy
2014-07-15 4:07 ` Lokesh Vutla
2014-07-15 6:59 ` Tony Lindgren
2014-07-15 3:51 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140709110051.GQ28884@atomide.com \
--to=tony@atomide.com \
--cc=a0393675@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).