From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [RFC PATCH v2 1/5] mfd: qpnp: add support for Qualcomm QPNP PMICs Date: Wed, 9 Jul 2014 15:34:26 +0100 Message-ID: <20140709143426.GC2635@lee--X1> References: <1404393243-7324-1-git-send-email-svarbanov@mm-sol.com> <1404393243-7324-2-git-send-email-svarbanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1404393243-7324-2-git-send-email-svarbanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stanimir Varbanov Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Kumar Gala , Grant Likely , Courtney Cavin , Josh Cartwright List-Id: devicetree@vger.kernel.org On Thu, 03 Jul 2014, Stanimir Varbanov wrote: > From: Josh Cartwright >=20 > The Qualcomm QPNP PMIC chips are components used with the > Snapdragon 800 series SoC family. This driver exists > largely as a glue mfd component, it exists to be an owner > of an SPMI regmap for children devices described in > device tree. >=20 > Signed-off-by: Josh Cartwright > Signed-off-by: Stanimir Varbanov > --- > drivers/mfd/Kconfig | 15 ++++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/qpnp-spmi.c | 129 +++++++++++++++++++++++++++++++++++++= ++++++++++ > 3 files changed, 145 insertions(+), 0 deletions(-) > create mode 100644 drivers/mfd/qpnp-spmi.c >=20 > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index ee8204c..258b733 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -524,6 +524,21 @@ config MFD_PM8921_CORE > Say M here if you want to include support for PM8921 chip as a mo= dule. > This will build a module called "pm8921-core". > =20 > +config MFD_QPNP_SPMI > + tristate "Qualcomm QPNP SPMI PMIC" > + depends on ARCH_QCOM || COMPILE_TEST > + depends on OF > + select MFD_CORE > + select REGMAP_SPMI > + help > + This enables support for the Qualcomm QPNP SPMI PMICs. > + These PMICs are currently used with the Snapdragon 800 series of > + SoCs. Note, that this will only be useful paired with descriptio= ns > + of the independent functions as children nodes in the device tree= =2E It would be helpful if the expected types of child devices were mentioned here in the help section. > + Say M here if you want to include support for the QPNP SPMI PMIC > + series as a module. The module will be called "qpnp-spmi". > + > config MFD_RDC321X > tristate "RDC R-321x southbridge" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 8afedba..31833d7 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -153,6 +153,7 @@ obj-$(CONFIG_MFD_SI476X_CORE) +=3D si476x-core.o > obj-$(CONFIG_MFD_CS5535) +=3D cs5535-mfd.o > obj-$(CONFIG_MFD_OMAP_USB_HOST) +=3D omap-usb-host.o omap-usb-tll.o > obj-$(CONFIG_MFD_PM8921_CORE) +=3D pm8921-core.o ssbi.o > +obj-$(CONFIG_MFD_QPNP_SPMI) +=3D qpnp-spmi.o > obj-$(CONFIG_TPS65911_COMPARATOR) +=3D tps65911-comparator.o > obj-$(CONFIG_MFD_TPS65090) +=3D tps65090.o > obj-$(CONFIG_MFD_AAT2870_CORE) +=3D aat2870-core.o > diff --git a/drivers/mfd/qpnp-spmi.c b/drivers/mfd/qpnp-spmi.c > new file mode 100644 > index 0000000..efd7d3e > --- /dev/null > +++ b/drivers/mfd/qpnp-spmi.c > @@ -0,0 +1,129 @@ > +/* Copyright (c) 2014, The Linux Foundation. All rights reserved. > + * Non-standard multi-line comment. First line should be blank. > + * This program is free software; you can redistribute it and/or mod= ify > + * it under the terms of the GNU General Public License version 2 an= d > + * only version 2 as published by the Free Software Foundation. No author? > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define QPNP_RESOURCE_SIZE 256 > + > +static const struct regmap_config qpnp_regmap_config =3D { > + .reg_bits =3D 16, > + .val_bits =3D 8, > + .max_register =3D 0xffff, > +}; > + > +static int qpnp_index_to_resource(struct device_node *np, int index, > + struct resource *res) > +{ > + const char *name =3D NULL; > + const __be32 *addrp; > + u64 addr; > + > + addrp =3D of_get_address(np, index, NULL, NULL); > + if (!addrp) > + return -EINVAL; > + > + addr =3D of_read_number(addrp, 1); > + if (addr =3D=3D OF_BAD_ADDR) > + return -EINVAL; > + > + of_property_read_string_index(np, "reg-names", index, &name); > + > + res->start =3D addr; > + res->end =3D addr + QPNP_RESOURCE_SIZE - 1; > + res->flags =3D IORESOURCE_REG; > + res->name =3D name ? name : np->name; > + > + return 0; > +} > + > +static int qpnp_add_device(struct spmi_device *root, struct device_n= ode *child) > +{ > + struct mfd_cell cell =3D {}; > + struct resource *res, *r; > + int num_resources =3D 0; > + const char *compat; > + int ret, i; > + > + compat =3D of_get_property(child, "compatible", NULL); > + if (!compat) > + return -ENODEV; > + > + while (of_get_address(child, num_resources, NULL, NULL)) > + num_resources++; > + > + if (!num_resources) > + return -ENODEV; > + > + res =3D kcalloc(num_resources, sizeof(*res), GFP_KERNEL); > + if (!res) > + return -ENOMEM; > + > + r =3D res; > + for (i =3D 0; i < num_resources; i++, r++) > + qpnp_index_to_resource(child, i, r); > + > + cell.name =3D kasprintf(GFP_KERNEL, "%x.%04x.%s", root->usid, > + (u16)res[0].start, child->name); > + cell.of_compatible =3D compat; > + cell.num_resources =3D num_resources; > + cell.resources =3D res; > + > + ret =3D mfd_add_devices(&root->dev, PLATFORM_DEVID_NONE, &cell, 1, > + NULL, 0, NULL); > + > + kfree(res); > + kfree(cell.name); > + > + return ret; > +} > + > +static int qpnp_probe(struct spmi_device *sdev) > +{ > + struct device_node *root =3D sdev->dev.of_node; > + struct device_node *child; > + struct regmap *regmap; > + > + regmap =3D devm_regmap_init_spmi_ext(sdev, &qpnp_regmap_config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + for_each_available_child_of_node(root, child) > + qpnp_add_device(sdev, child); This entire driver looks like a re-write of of_platform_populate(). Why? > + return 0; > +} > + > +static void qpnp_remove(struct spmi_device *sdev) > +{ > + mfd_remove_devices(&sdev->dev); > +} > + > +static const struct of_device_id qpnp_id_table[] =3D { > + { .compatible =3D "qcom,qpnp-spmi", }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, qpnp_id_table); > + > +static struct spmi_driver qpnp_driver =3D { > + .probe =3D qpnp_probe, > + .remove =3D qpnp_remove, > + .driver =3D { > + .name =3D "qpnp-spmi", > + .of_match_table =3D qpnp_id_table, > + }, > +}; > +module_spmi_driver(qpnp_driver); --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html