From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 03/24] mfd: max77686: Don't define dummy function if OF isn't enabled Date: Wed, 9 Jul 2014 15:50:10 +0100 Message-ID: <20140709145010.GE2635@lee--X1> References: <1404505467-26526-1-git-send-email-javier.martinez@collabora.co.uk> <1404505467-26526-4-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1404505467-26526-4-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-kernel-owner@vger.kernel.org To: Javier Martinez Canillas Cc: Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Tomeu Vizoso , Krzysztof Kozlowski , Yadwinder Singh Brar , Tushar Behera , Andreas Farber , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, 04 Jul 2014, Javier Martinez Canillas wrote: > When the CONFIG_OF option was not enabled, a dummy function > max77686_i2c_parse_dt_pdata() was defined since this is called > unconditionally on probe(). Just always define the real function > and conditionally call it if CONFIG_OF is enabled instead. >=20 > Signed-off-by: Javier Martinez Canillas > --- > drivers/mfd/max77686.c | 10 +--------- Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog