From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
devicetree@vger.kernel.org, linux-sh@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/13] [RFC] mmc: tmio-mmc: Add support for SDHI on new R-Car Gen2 SoCs
Date: Fri, 11 Jul 2014 11:19:04 +0200 [thread overview]
Message-ID: <20140711091904.GP12420@verge.net.au> (raw)
In-Reply-To: <1404908623-909-12-git-send-email-geert+renesas@glider.be>
On Wed, Jul 09, 2014 at 02:23:41PM +0200, Geert Uytterhoeven wrote:
> - r8a7792 (R-Car V2H)
> - r8a7793 (R-Car M2-N)
> - r8a7794 (R-Car E2)
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
This seems to be in keeping with the approach we ave taken for these
SoCs for other drivers. And from that point of view it is fine by me.
But I wonder how sure are we that the hardware on the SoCs will work
with this approach.
> ---
> Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 3 +++
> drivers/mmc/host/sh_mobile_sdhi.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> index fa0f327cde01..400b640fabc7 100644
> --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> @@ -19,6 +19,9 @@ Required properties:
> "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
> "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
> "renesas,sdhi-r8a7791" - SDHI IP on R8A7791 SoC
> + "renesas,sdhi-r8a7792" - SDHI IP on R8A7792 SoC
> + "renesas,sdhi-r8a7793" - SDHI IP on R8A7793 SoC
> + "renesas,sdhi-r8a7794" - SDHI IP on R8A7794 SoC
>
> Optional properties:
> - toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index 91058dabd11a..443c20969bd7 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> @@ -68,6 +68,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = {
> { .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7792", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7793", .data = &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7794", .data = &of_rcar_gen2_compatible, },
> {},
> };
> MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match);
> --
> 1.9.1
>
next prev parent reply other threads:[~2014-07-11 9:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 12:23 [PATCH 00/13] ARM: shmobile: DT bindings and DTS updates Geert Uytterhoeven
2014-07-09 12:23 ` [PATCH 01/13] of: Add vendor prefix for Sitronix Geert Uytterhoeven
2014-07-09 12:23 ` [PATCH 03/13] irqchip: renesas-irqc: Add DT binding documentation Geert Uytterhoeven
2014-07-11 9:07 ` Simon Horman
2014-07-09 12:23 ` [PATCH 04/13] mmc: tmio-mmc: Add renesas,sdhi-r8a7791 to " Geert Uytterhoeven
2014-07-09 12:31 ` Ulf Hansson
2014-07-09 12:23 ` [PATCH 05/13] thermal: rcar: Document SoC-specific bindings Geert Uytterhoeven
2014-07-11 9:13 ` Simon Horman
2014-07-15 14:48 ` Zhang Rui
2014-07-16 2:16 ` Kuninori Morimoto
2014-07-18 7:46 ` Simon Horman
2014-07-18 9:11 ` Kuninori Morimoto
2014-08-05 8:57 ` Geert Uytterhoeven
2014-08-06 0:30 ` Kuninori Morimoto
2014-08-06 7:09 ` Geert Uytterhoeven
2014-07-09 12:23 ` [PATCH 06/13] sh-pfc: Add renesas,pfc-r8a7791 to binding documentation Geert Uytterhoeven
2014-07-09 12:52 ` Laurent Pinchart
2014-07-10 9:25 ` Linus Walleij
[not found] ` <1404908623-909-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-07-09 12:23 ` [PATCH 02/13] irqchip: renesas-intc-irqpin: Document SoC-specific bindings Geert Uytterhoeven
2014-07-11 9:06 ` Simon Horman
2014-07-09 12:23 ` [PATCH 07/13] ARM: shmobile: r8a73a4 dtsi: Add SoC-specific irqc compatible property Geert Uytterhoeven
2014-07-11 9:15 ` Simon Horman
2014-07-09 12:23 ` [PATCH 08/13] ARM: shmobile: r8a73a4 dtsi: Add SoC-specific thermal " Geert Uytterhoeven
[not found] ` <1404908623-909-9-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-07-11 9:15 ` Simon Horman
2014-07-09 12:23 ` [PATCH 09/13] ARM: shmobile: r8a7779 " Geert Uytterhoeven
2014-07-11 9:16 ` Simon Horman
2014-07-09 12:23 ` [PATCH 10/13] [RFC] ARM: dts: Add shmobile platform device tree bindings documentation Geert Uytterhoeven
2014-07-11 9:17 ` Simon Horman
2014-07-11 14:26 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXP6GfO7OEnXU8x4Sn5j8_tA2nnrFANr1sriB-B4BYoOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-11 15:09 ` Simon Horman
2014-07-09 12:23 ` [PATCH 11/13] [RFC] mmc: tmio-mmc: Add support for SDHI on new R-Car Gen2 SoCs Geert Uytterhoeven
2014-07-11 9:19 ` Simon Horman [this message]
2014-07-09 12:23 ` [PATCH 12/13] [RFC] thermal: rcar: Add binding docs for " Geert Uytterhoeven
2014-07-11 9:21 ` Simon Horman
2014-07-11 9:23 ` Simon Horman
2014-07-09 12:23 ` [PATCH 13/13] [RFC] irqchip: renesas-irqc: " Geert Uytterhoeven
2014-07-11 9:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711091904.GP12420@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).