From: Thierry Reding <thierry.reding@gmail.com>
To: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: tegra: Fix typoed ams,ext-control properties
Date: Fri, 11 Jul 2014 15:04:57 +0200 [thread overview]
Message-ID: <20140711130456.GB10827@ulmo> (raw)
In-Reply-To: <1404931997-7118-1-git-send-email-ttynkkynen@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Wed, Jul 09, 2014 at 09:53:17PM +0300, Tuomas Tynkkynen wrote:
> The property for enabling external rail control on the AS3722 is
> ams,ext-control, not ams,external-control. Since the external rail
> control property was previously being ignored, LP1 suspend on these
> boards wasn't actually turning the CPU rail off at all.
>
> Signed-off-by: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> ---
> So here's a dilemma, either change the existing DTs, change the
> binding + driver, or make the driver recognize both properties.
> I chose the first one since the old behaviour was broken in the
> first place and the old DTs stay as buggy as they were before.
>
> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 6 +++---
> arch/arm/boot/dts/tegra124-venice2.dts | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
Applied to the for-3.17/dt branch. Thanks.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-07-11 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 18:53 [PATCH] ARM: tegra: Fix typoed ams,ext-control properties Tuomas Tynkkynen
2014-07-11 13:04 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140711130456.GB10827@ulmo \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=ttynkkynen@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).