From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv2 06/10] ARM: DRA7: hwmod_data: Add mailbox hwmod data Date: Tue, 15 Jul 2014 06:30:13 -0700 Message-ID: <20140715133013.GA2605@atomide.com> References: <1405115083-52977-1-git-send-email-s-anna@ti.com> <1405115083-52977-7-git-send-email-s-anna@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1405115083-52977-7-git-send-email-s-anna@ti.com> Sender: linux-omap-owner@vger.kernel.org To: Suman Anna Cc: Paul Walmsley , Dave Gerlach , Jassi Brar , Pavel Machek , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Rajendra Nayak List-Id: devicetree@vger.kernel.org * Suman Anna [140711 14:47]: > Add the hwmod data for the 13 instances of the system mailbox > IP in DRA7 SoC. The patch is needed for performing a soft-reset > while configuring the respective mailbox instance, otherwise is > a non-essential change for functionality. The modules are smart > idled on reset, and the IP module mode is hardware controlled. > > Cc: Rajendra Nayak > Cc: Paul Walmsley > Signed-off-by: Suman Anna > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 305 ++++++++++++++++++++++++++++++ > 1 file changed, 305 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > index 20b4398..e35f5b1 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > @@ -939,6 +939,194 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = { > }; > > /* > + * 'mailbox' class > + * > + */ > + > +static struct omap_hwmod_class_sysconfig dra7xx_mailbox_sysc = { > + .rev_offs = 0x0000, > + .sysc_offs = 0x0010, > + .sysc_flags = (SYSC_HAS_RESET_STATUS | SYSC_HAS_SIDLEMODE | > + SYSC_HAS_SOFTRESET), > + .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), > + .sysc_fields = &omap_hwmod_sysc_type2, > +}; > + > +static struct omap_hwmod_class dra7xx_mailbox_hwmod_class = { > + .name = "mailbox", > + .sysc = &dra7xx_mailbox_sysc, > +}; Hmm I'm seeing just the following MAILBOX_SYSCONFIG in at least am57xx TRM: 31:4 RESERVED 3:2 SIDLEMODE 0 = force-idle 1 = no-idle, 2 = smart-idle, 3 = reserved 1 RESERVED 0 SOFTRESET So it seems that SYSC_HAS_RESET_STATUS above is wrong? Can you guys please check. Regards, Tony