* [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW @ 2014-07-08 13:16 Mugunthan V N [not found] ` <1404825399-10330-1-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Mugunthan V N @ 2014-07-08 13:16 UTC (permalink / raw) To: linux-omap Cc: devicetree, linux-arm-kernel, linux-kernel, Mugunthan V N, Rajendra Nayak, Tony Lindgren, Russell King, Paul Walmsley Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC Cc: Rajendra Nayak <rnayak@ti.com> Cc: Tony Lindgren <tony@atomide.com> Cc: Russell King <linux@arm.linux.org.uk> Cc: Paul Walmsley <paul@pwsan.com> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com> --- This patch was already send twice on 2013-10-18 and 2014-05-13. Adding more people in Cc to review the patch. --- arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 65 +++++++++++++++++++++++++++++++ 1 file changed, 65 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c index 20b4398..45b5113 100644 --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c @@ -273,6 +273,56 @@ static struct omap_hwmod dra7xx_ctrl_module_wkup_hwmod = { }; /* + * 'gmac' class + * cpsw/gmac sub system + */ +static struct omap_hwmod_class_sysconfig dra7xx_gmac_sysc = { + .rev_offs = 0x0, + .sysc_offs = 0x8, + .syss_offs = 0x4, + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE | + SYSS_HAS_RESET_STATUS), + .idlemodes = (SIDLE_FORCE | SIDLE_NO | MSTANDBY_FORCE | + MSTANDBY_NO), + .sysc_fields = &omap_hwmod_sysc_type3, +}; + +static struct omap_hwmod_class dra7xx_gmac_hwmod_class = { + .name = "gmac", + .sysc = &dra7xx_gmac_sysc, +}; + +static struct omap_hwmod dra7xx_gmac_hwmod = { + .name = "gmac", + .class = &dra7xx_gmac_hwmod_class, + .clkdm_name = "gmac_clkdm", + .flags = (HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY), + .main_clk = "dpll_gmac_ck", + .mpu_rt_idx = 1, + .prcm = { + .omap4 = { + .clkctrl_offs = DRA7XX_CM_GMAC_GMAC_CLKCTRL_OFFSET, + .context_offs = DRA7XX_RM_GMAC_GMAC_CONTEXT_OFFSET, + .modulemode = MODULEMODE_SWCTRL, + }, + }, +}; + +/* + * 'mdio' class + */ +static struct omap_hwmod_class dra7xx_mdio_hwmod_class = { + .name = "davinci_mdio", +}; + +static struct omap_hwmod dra7xx_mdio_hwmod = { + .name = "davinci_mdio", + .class = &dra7xx_mdio_hwmod_class, + .clkdm_name = "gmac_clkdm", + .main_clk = "dpll_gmac_ck", +}; + +/* * 'dcan' class * */ @@ -1999,6 +2049,19 @@ static struct omap_hwmod_ocp_if dra7xx_l4_wkup__ctrl_module_wkup = { .user = OCP_USER_MPU | OCP_USER_SDMA, }; +static struct omap_hwmod_ocp_if dra7xx_l4_per2__cpgmac0 = { + .master = &dra7xx_l4_per2_hwmod, + .slave = &dra7xx_gmac_hwmod, + .clk = "dpll_gmac_ck", + .user = OCP_USER_MPU, +}; + +static struct omap_hwmod_ocp_if dra7xx_gmac__mdio = { + .master = &dra7xx_gmac_hwmod, + .slave = &dra7xx_mdio_hwmod, + .user = OCP_USER_MPU, +}; + /* l4_wkup -> dcan1 */ static struct omap_hwmod_ocp_if dra7xx_l4_wkup__dcan1 = { .master = &dra7xx_l4_wkup_hwmod, @@ -2642,6 +2705,8 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = { &dra7xx_l4_wkup__ctrl_module_wkup, &dra7xx_l4_wkup__dcan1, &dra7xx_l4_per2__dcan2, + &dra7xx_l4_per2__cpgmac0, + &dra7xx_gmac__mdio, &dra7xx_l4_cfg__dma_system, &dra7xx_l3_main_1__dss, &dra7xx_l3_main_1__dispc, -- 2.0.0.390.gcb682f8 ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <1404825399-10330-1-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org>]
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <1404825399-10330-1-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org> @ 2014-07-09 9:55 ` Sebastian Andrzej Siewior 2014-07-09 10:01 ` Sebastian Andrzej Siewior 2014-07-17 7:49 ` Tony Lindgren 1 sibling, 1 reply; 11+ messages in thread From: Sebastian Andrzej Siewior @ 2014-07-09 9:55 UTC (permalink / raw) To: Mugunthan V N Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, Paul Walmsley, Russell King, Tony Lindgren, Rajendra Nayak, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 2014-07-08 18:46:39 [+0530], Mugunthan V N wrote: > Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC I reverted my patch, applied this one and after boot I got: |platform 48485000.mdio: Cannot lookup hwmod 'davinci_mdio' |cpsw 48484000.ethernet: _od_fail_runtime_resume: FIXME: missing hwmod/omap_dev info |davinci_mdio 48485000.mdio: failed to get device clock |davinci_mdio: probe of 48485000.mdio failed with error -2 |cpsw 48484000.ethernet: Random MACID = 46:c6:34:6f:8d:c6 | (null): fck is not found with no eth0. Is there something with my setup? I still have the device tree pieces I posted (in case there is something wrong with them). Sebastian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW 2014-07-09 9:55 ` Sebastian Andrzej Siewior @ 2014-07-09 10:01 ` Sebastian Andrzej Siewior [not found] ` <20140709100147.GB25154-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Sebastian Andrzej Siewior @ 2014-07-09 10:01 UTC (permalink / raw) To: Mugunthan V N Cc: devicetree, Paul Walmsley, Russell King, Tony Lindgren, Rajendra Nayak, linux-kernel, linux-omap, linux-arm-kernel On 2014-07-09 11:55:52 [+0200], Sebastian Andrzej Siewior wrote: > On 2014-07-08 18:46:39 [+0530], Mugunthan V N wrote: > > Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC > > I reverted my patch, applied this one and after boot I got: Oh me dum dum. I had --dry-run… Acked-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> This is basically what Tony hasked me to do: No IRQ numbers & iomem. Sebastian ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20140709100147.GB25154-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>]
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <20140709100147.GB25154-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> @ 2014-07-09 10:11 ` Tony Lindgren 2014-07-15 20:21 ` Paul Walmsley 1 sibling, 0 replies; 11+ messages in thread From: Tony Lindgren @ 2014-07-09 10:11 UTC (permalink / raw) To: Sebastian Andrzej Siewior Cc: Mugunthan V N, devicetree-u79uwXL29TY76Z2rM5mHXA, Paul Walmsley, Russell King, Rajendra Nayak, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r * Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> [140709 03:03]: > On 2014-07-09 11:55:52 [+0200], Sebastian Andrzej Siewior wrote: > > On 2014-07-08 18:46:39 [+0530], Mugunthan V N wrote: > > > Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC > > > > I reverted my patch, applied this one and after boot I got: > Oh me dum dum. I had --dry-run… > > Acked-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > This is basically what Tony hasked me to do: No IRQ numbers & iomem. OK great thanks for testing :) Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <20140709100147.GB25154-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> 2014-07-09 10:11 ` Tony Lindgren @ 2014-07-15 20:21 ` Paul Walmsley 2014-07-16 7:06 ` Sebastian Andrzej Siewior 1 sibling, 1 reply; 11+ messages in thread From: Paul Walmsley @ 2014-07-15 20:21 UTC (permalink / raw) To: Sebastian Andrzej Siewior, Mugunthan V N Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Tony Lindgren, Rajendra Nayak, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r [-- Attachment #1: Type: TEXT/PLAIN, Size: 818 bytes --] Hi Sebastian, On Wed, 9 Jul 2014, Sebastian Andrzej Siewior wrote: > On 2014-07-09 11:55:52 [+0200], Sebastian Andrzej Siewior wrote: > > On 2014-07-08 18:46:39 [+0530], Mugunthan V N wrote: > > > Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC > > > > I reverted my patch, applied this one and after boot I got: > Oh me dum dum. I had --dry-run… > > Acked-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > This is basically what Tony hasked me to do: No IRQ numbers & iomem. Sorry - I'm a bit confused - Sebastian, did you test this one? If so, is it okay to add a Tested-by from you? Mugunthan, could you please get a Reviewed-by: from one of the folks on the DRA7xx SoC integration reviewers list that I sent earlier? - Paul ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW 2014-07-15 20:21 ` Paul Walmsley @ 2014-07-16 7:06 ` Sebastian Andrzej Siewior [not found] ` <20140716070643.GC3378-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Sebastian Andrzej Siewior @ 2014-07-16 7:06 UTC (permalink / raw) To: Paul Walmsley Cc: Mugunthan V N, devicetree, Russell King, Tony Lindgren, Rajendra Nayak, linux-kernel, linux-omap, linux-arm-kernel On 2014-07-15 20:21:21 [+0000], Paul Walmsley wrote: > Hi Sebastian, Hi Paul, > > Acked-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> > > > > This is basically what Tony hasked me to do: No IRQ numbers & iomem. > > Sorry - I'm a bit confused - Sebastian, did you test this one? If so, is > it okay to add a Tested-by from you? Tested-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc> > - Paul Sebastian ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20140716070643.GC3378-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>]
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <20140716070643.GC3378-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> @ 2014-07-16 18:57 ` Paul Walmsley [not found] ` <alpine.DEB.2.02.1407161854360.23074-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Paul Walmsley @ 2014-07-16 18:57 UTC (permalink / raw) To: Sebastian Andrzej Siewior, Mugunthan V N, Tony Lindgren Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Rajendra Nayak, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Wed, 16 Jul 2014, Sebastian Andrzej Siewior wrote: > On 2014-07-15 20:21:21 [+0000], Paul Walmsley wrote: > > > > Acked-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > > > > > This is basically what Tony hasked me to do: No IRQ numbers & iomem. > > > > Sorry - I'm a bit confused - Sebastian, did you test this one? If so, is > > it okay to add a Tested-by from you? > > Tested-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> Thanks Sebastian. Mugunthan, next step would be for you to get a Reviewed-by: by someone who has access to the (non-public) DRA7xx TRM, and can review for SoC integration. Since Rajendra is no longer at TI, the right person is probably Tony. Then this patch should be mergeable. - Paul -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <alpine.DEB.2.02.1407161854360.23074-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>]
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <alpine.DEB.2.02.1407161854360.23074-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org> @ 2014-07-17 7:50 ` Tony Lindgren [not found] ` <20140717075028.GG18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Tony Lindgren @ 2014-07-17 7:50 UTC (permalink / raw) To: Paul Walmsley Cc: Sebastian Andrzej Siewior, Mugunthan V N, devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Rajendra Nayak, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r * Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org> [140716 11:59]: > On Wed, 16 Jul 2014, Sebastian Andrzej Siewior wrote: > > > On 2014-07-15 20:21:21 [+0000], Paul Walmsley wrote: > > > > > > Acked-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > > > > > > > This is basically what Tony hasked me to do: No IRQ numbers & iomem. > > > > > > Sorry - I'm a bit confused - Sebastian, did you test this one? If so, is > > > it okay to add a Tested-by from you? > > > > Tested-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > Thanks Sebastian. > > Mugunthan, next step would be for you to get a Reviewed-by: by someone who > has access to the (non-public) DRA7xx TRM, and can review for SoC > integration. Since Rajendra is no longer at TI, the right person is > probably Tony. > > Then this patch should be mergeable. Yeah took a look at it and acked it. Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20140717075028.GG18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <20140717075028.GG18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> @ 2014-07-22 18:53 ` Paul Walmsley 0 siblings, 0 replies; 11+ messages in thread From: Paul Walmsley @ 2014-07-22 18:53 UTC (permalink / raw) To: Tony Lindgren Cc: Sebastian Andrzej Siewior, Mugunthan V N, devicetree-u79uwXL29TY76Z2rM5mHXA, Russell King, Rajendra Nayak, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-omap-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On Thu, 17 Jul 2014, Tony Lindgren wrote: > * Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org> [140716 11:59]: > > On Wed, 16 Jul 2014, Sebastian Andrzej Siewior wrote: > > > > > On 2014-07-15 20:21:21 [+0000], Paul Walmsley wrote: > > > > > > > > Acked-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > > > > > > > > > This is basically what Tony hasked me to do: No IRQ numbers & iomem. > > > > > > > > Sorry - I'm a bit confused - Sebastian, did you test this one? If so, is > > > > it okay to add a Tested-by from you? > > > > > > Tested-by: Sebastian Andrzej Siewior <sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> > > > > Thanks Sebastian. > > > > Mugunthan, next step would be for you to get a Reviewed-by: by someone who > > has access to the (non-public) DRA7xx TRM, and can review for SoC > > integration. Since Rajendra is no longer at TI, the right person is > > probably Tony. > > > > Then this patch should be mergeable. > > Yeah took a look at it and acked it. Thanks queued for 3.17. - Paul -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <1404825399-10330-1-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org> 2014-07-09 9:55 ` Sebastian Andrzej Siewior @ 2014-07-17 7:49 ` Tony Lindgren [not found] ` <20140717074948.GF18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 1 sibling, 1 reply; 11+ messages in thread From: Tony Lindgren @ 2014-07-17 7:49 UTC (permalink / raw) To: Mugunthan V N Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Rajendra Nayak, Russell King, Paul Walmsley * Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org> [140708 06:18]: > Adding hwmod data for CPSW and MDIO which is present in DRA7xx SoC > > Cc: Rajendra Nayak <rnayak-l0cyMroinI0@public.gmane.org> > Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> > Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> > Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org> > Signed-off-by: Mugunthan V N <mugunthanvnm-l0cyMroinI0@public.gmane.org> > --- > > This patch was already send twice on 2013-10-18 and 2014-05-13. Adding > more people in Cc to review the patch. > > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 65 +++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > index 20b4398..45b5113 100644 > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > @@ -273,6 +273,56 @@ static struct omap_hwmod dra7xx_ctrl_module_wkup_hwmod = { > }; > > /* > + * 'gmac' class > + * cpsw/gmac sub system > + */ > +static struct omap_hwmod_class_sysconfig dra7xx_gmac_sysc = { > + .rev_offs = 0x0, > + .sysc_offs = 0x8, > + .syss_offs = 0x4, > + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE | > + SYSS_HAS_RESET_STATUS), > + .idlemodes = (SIDLE_FORCE | SIDLE_NO | MSTANDBY_FORCE | > + MSTANDBY_NO), > + .sysc_fields = &omap_hwmod_sysc_type3, > +}; We seem to have this layout WR_SOFT_RESET and WR_CONTROL in the TRM: WR_SOFT_RESET [0] SOFT_RESET WR_CONTROL [3:2] MMR_STDBYMODE 0 = force-idle, 1 = no-standby [1:0] MMR_IDLEMODE 0 = force-idle, 1 = no-idle And so it seems to match what am33xx also has for am33xx_cpgmac_sysc and am33xx TRM for 14.5.9 CONTROL register. So as far as I'm concerned: Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20140717074948.GF18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>]
* Re: [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW [not found] ` <20140717074948.GF18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> @ 2014-07-22 10:11 ` Mugunthan V N 0 siblings, 0 replies; 11+ messages in thread From: Mugunthan V N @ 2014-07-22 10:11 UTC (permalink / raw) To: Paul Walmsley Cc: Tony Lindgren, linux-omap-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Russell King On Thursday 17 July 2014 01:19 PM, Tony Lindgren wrote: > We seem to have this layout WR_SOFT_RESET and WR_CONTROL in the TRM: > > WR_SOFT_RESET > [0] SOFT_RESET > > WR_CONTROL > [3:2] MMR_STDBYMODE 0 = force-idle, 1 = no-standby > [1:0] MMR_IDLEMODE 0 = force-idle, 1 = no-idle > > And so it seems to match what am33xx also has for am33xx_cpgmac_sysc > and am33xx TRM for 14.5.9 CONTROL register. So as far as I'm concerned: > > Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Paul, Can you pull this patch as Tony acked the patch. Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-07-22 18:53 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-08 13:16 [Re-send PATCH 1/1] arm: dra7xx: Add hwmod data for MDIO and CPSW Mugunthan V N [not found] ` <1404825399-10330-1-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org> 2014-07-09 9:55 ` Sebastian Andrzej Siewior 2014-07-09 10:01 ` Sebastian Andrzej Siewior [not found] ` <20140709100147.GB25154-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> 2014-07-09 10:11 ` Tony Lindgren 2014-07-15 20:21 ` Paul Walmsley 2014-07-16 7:06 ` Sebastian Andrzej Siewior [not found] ` <20140716070643.GC3378-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org> 2014-07-16 18:57 ` Paul Walmsley [not found] ` <alpine.DEB.2.02.1407161854360.23074-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org> 2014-07-17 7:50 ` Tony Lindgren [not found] ` <20140717075028.GG18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2014-07-22 18:53 ` Paul Walmsley 2014-07-17 7:49 ` Tony Lindgren [not found] ` <20140717074948.GF18374-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2014-07-22 10:11 ` Mugunthan V N
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).