From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine =?iso-8859-1?Q?T=E9nart?= Subject: Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx Date: Wed, 16 Jul 2014 11:15:33 +0200 Message-ID: <20140716091533.GB28151@kwain> References: <1405499166-6726-1-git-send-email-antoine.tenart@free-electrons.com> <1405499166-6726-8-git-send-email-antoine.tenart@free-electrons.com> <42036198.zWkqnus6xa@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <42036198.zWkqnus6xa@wuerfel> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Antoine =?iso-8859-1?Q?T=E9nart?= , sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Arnd, On Wed, Jul 16, 2014 at 10:41:10AM +0200, Arnd Bergmann wrote: > On Wednesday 16 July 2014 10:26:01 Antoine T=E9nart wrote: > > + > > + if (priv->dma_mask) { > > + ret =3D dma_coerce_mask_and_coherent(&pdev->dev, pr= iv->dma_mask); > > + if (ret) > > + return ret; > > + } > > + > >=20 >=20 > As mentioned in my comment for the binding, this is the wrong way to = do it. > Russell has in the past converted all drivers that did this manually = to=20 > do dma_coerce_mask_and_coherent() so we can spot them more easily, bu= t we > should really be doing this better for new drivers. >=20 > Can you describe what the restriction is that you want to put on the = dma mask? Some people wanted the possibility to set the DMA mask as this USB2 CI driver does not do specific Berlin operation and can be reused later. I don't particularly need to call dma_coerce_mask_and_coherent() in my case, as far as I know. They can maybe give the restrictions they might want to put on the DMA mask. Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html