From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v7 07/24] mfd: max77686: Remove unneeded OOM error message Date: Fri, 18 Jul 2014 09:18:52 +0100 Message-ID: <20140718081852.GQ30888@lee--X1> References: <1404505467-26526-1-git-send-email-javier.martinez@collabora.co.uk> <1404505467-26526-8-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1404505467-26526-8-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Doug Anderson , Olof Johansson , Tomeu Vizoso , Krzysztof Kozlowski , Yadwinder Singh Brar , Tushar Behera , Andreas Farber , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 04 Jul 2014, Javier Martinez Canillas wrote: > There is no need to print out-of-memory errors since this is already > done by the memory management subsystem which even calls dump_stack()= =2E >=20 > Signed-off-by: Javier Martinez Canillas > --- > drivers/mfd/max77686.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied now, thanks. > diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c > index 87fe52e..8650832 100644 > --- a/drivers/mfd/max77686.c > +++ b/drivers/mfd/max77686.c > @@ -107,10 +107,8 @@ static struct max77686_platform_data *max77686_i= 2c_parse_dt_pdata(struct device > struct max77686_platform_data *pd; > =20 > pd =3D devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL); > - if (!pd) { > - dev_err(dev, "could not allocate memory for pdata\n"); > + if (!pd) > return NULL; > - } > =20 > dev->platform_data =3D pd; > return pd; --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html