Re: [PATCH v2 1/2] pwm: add this patch to introduce for rk-pwm and vop-pwm

[Thierry Reding <thierry.reding@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2597 bytes --]

On Sat, Jul 19, 2014 at 08:55:28PM +0800, Caesar Wang wrote:
> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-rockchip.txt | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt b/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt
> index 3182126..bb6e7f1 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.txt
> @@ -1,11 +1,14 @@
>  Rockchip PWM controller
>  
>  Required properties:
> - - compatible: should be "rockchip,rk2928-pwm"
> - - reg: physical base address and length of the controller's registers
> - - clocks: phandle and clock specifier of the PWM reference clock
> - - #pwm-cells: should be 2. See pwm.txt in this directory for a
> -   description of the cell format.

Can you please stick to the original format rather than removing the
space in the first column? It makes it difficult to see what's being
changed by this patch.

> +- compatible: should be "rockchip,<name>-pwm"should be one of following:

I think it should be either 'should be "rockchip,<name>-pwm"' or 'should
be one of the following', not both.

> +    "rockchip,rk2928-pwm" - support the old version PWM for RK29xx,RK3066,RK3188 SoCs.
> +    "rockchip,rk3288-pwm" - support the new version PWM for RK3036,RK3288 SoCs.
> +    "rockchip,vop-pwm" - support rockchip integrated VOP-PWM for RK32 SoCs.

"old version PWM" and "new version PWM" can be dropped. Maybe:

	"rockchip,rk2928-pwm": found on RK29xx, RK3066 and RK3188 SoCs
	"rockchip,rk3288-pwm": found on RK3036 and RK3288 SoCs
	"rockchip,vop-pwm": found integrated in VOP on RK32xx SoCs

? Could you explain a little what this VOP is? Also since the above says
that "rockchip,rk3288-pwm" is supported on RK3036, the compatible value
should really be "rockchip,rk3036-pwm" since we usually list the chip
that an IP block was first used in (I'm assuming here that RK3036 is
older than RK3288).

> +- reg: physical base address and length of the controller's registers.
> +- clocks: phandle and clock specifier of the PWM reference clock.
> +- #pwm-cells: should be 2. See pwm.txt in this directory for a
> +  description of the cell format.

These are all unchanged (except for the first column's space being
removed and the full-stops for reg and clocks properties). Please keep
with the original formatting so that it becomes obvious what the patch
changes.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]