From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 2/2] iio: exynos-adc: add experimental touchscreen support Date: Mon, 21 Jul 2014 07:44:42 -0700 Message-ID: <20140721144442.GB9112@core.coreip.homeip.net> References: <1405663186-26464-1-git-send-email-cw00.choi@samsung.com> <53CBC969.4090704@kernel.org> <20140720202842.GB18347@core.coreip.homeip.net> <5158672.dMAnnUQc7Z@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5158672.dMAnnUQc7Z@wuerfel> Sender: linux-samsung-soc-owner@vger.kernel.org To: Arnd Bergmann Cc: Jonathan Cameron , linux-arm-kernel@lists.infradead.org, Chanwoo Choi , ch.naveen@samsung.com, mark.rutland@arm.com, devicetree@vger.kernel.org, kgene.kim@samsung.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-iio@vger.kernel.org, t.figa@samsung.com, rdunlap@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com, robh+dt@kernel.org, galak@codeaurora.org, heiko.stuebner@bq.com, Ben Dooks , linux-input List-Id: devicetree@vger.kernel.org On Mon, Jul 21, 2014 at 12:23:58PM +0200, Arnd Bergmann wrote: > On Sunday 20 July 2014 13:28:42 Dmitry Torokhov wrote: > > On Sun, Jul 20, 2014 at 02:51:37PM +0100, Jonathan Cameron wrote: > > > >>+ > > > >>+ do { > > > >>+ ret =exynos_read_s3c64xx_ts(dev, NULL, &x, &y, IIO_CHAN_INFO_RAW); > > > >= exynos > > > >>+ if (ret == -ETIMEDOUT) > > > >>+ break; > > > >>+ > > > >>+ pressed = x & y & ADC_DATX_PRESSED; > > > >>+ if (!pressed) > > > >>+ break; > > > >>+ > > > >>+ input_report_abs(info->input, ABS_X, x & ADC_DATX_MASK); > > > >>+ input_report_abs(info->input, ABS_Y, y & ADC_DATX_MASK); > > > >>+ input_report_key(info->input, BTN_TOUCH, 1); > > > >>+ input_sync(info->input); > > > >>+ > > > >>+ msleep(1); > > > >>+ } while (1); > > > > It would be nice to actually close the device even if someone is > > touching screen. Please implement open/close methods and have them set a > > flag that you would check here. > > Ok. I think it's even better to move the request_irq() into the open function, > which will avoid the flag and defer the error handling into the actual opening, > as well as syncing the running irq with the close function. I do not quite like acquiring resources needed in open. I think drivers should do all resource acquisition in probe() and leave open()/close() to activate/quiesce devices. > > > > >>+ /* data from s3c2410_ts driver */ > > > >>+ info->input->name = "S3C24xx TouchScreen"; > > > >>+ info->input->id.bustype = BUS_HOST; > > > >>+ info->input->id.vendor = 0xDEAD; > > > >>+ info->input->id.product = 0xBEEF; > > > > You do not need to fill these entries with fake data. > > Ok, I wondered about this, but didn't want to change too much from > the old driver (I changed the version number). > > > > >>+ info->input->id.version = 0x0200; > > Do I need this? Not really. Thanks. -- Dmitry