From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 1/4] mfd: pm8xxx-spmi: add support for Qualcomm SPMI PMICs Date: Tue, 22 Jul 2014 12:03:41 +0100 Message-ID: <20140722110341.GE8406@lee--X1> References: <1405613855-27572-1-git-send-email-svarbanov@mm-sol.com> <1405613855-27572-2-git-send-email-svarbanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1405613855-27572-2-git-send-email-svarbanov@mm-sol.com> Sender: linux-kernel-owner@vger.kernel.org To: Stanimir Varbanov Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Samuel Ortiz , Ian Campbell , Pawel Moll , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Courtney Cavin , Bjorn Andersson , Josh Cartwright List-Id: devicetree@vger.kernel.org On Thu, 17 Jul 2014, Stanimir Varbanov wrote: > From: Josh Cartwright >=20 > The Qualcomm SPMI PMIC chips are components used with the > Snapdragon 800 series SoC family. This driver exists > largely as a glue mfd component, it exists to be an owner > of an SPMI regmap for children devices described in > device tree. >=20 > Signed-off-by: Stanimir Varbanov Needs to be signed off by the author. > --- > drivers/mfd/Kconfig | 16 +++++++++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/pm8xxx-spmi.c | 63 +++++++++++++++++++++++++++++++++++= ++++++++++ > 3 files changed, 80 insertions(+), 0 deletions(-) > create mode 100644 drivers/mfd/pm8xxx-spmi.c [...] > +++ b/drivers/mfd/pm8xxx-spmi.c > @@ -0,0 +1,63 @@ > +/* > + * Copyright (c) 2014, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or mod= ify > + * it under the terms of the GNU General Public License version 2 an= d > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ There should be a '\n' here. > +#include > +#include > +#include > +#include > +#include [...] > +MODULE_DESCRIPTION("PM8XXX SPMI PMIC driver"); > +MODULE_ALIAS("platform:" KBUILD_MODNAME); > +MODULE_AUTHOR("The Linux Foundation"); The Linux Foundation did not write this patch. > +MODULE_LICENSE("GPL v2"); Appart from that: Acked-by: Lee Jones --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog