From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/2] Added dts defintion for Lenovo ix4-300d nas Date: Wed, 23 Jul 2014 16:14:43 +0200 Message-ID: <20140723141443.GC2856@lunn.ch> References: <1406117232-5962-1-git-send-email-yahoo@perenite.com> <20140723134534.GF23220@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140723134534.GF23220-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Cooper Cc: benoitm974 , benoitm-+V3Jd3LB6RBWk0Htik3J/w@public.gmane.org, Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrew Lunn , Gregory CLEMENT , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Benoit, > > > + }; > > + > > + serial@12000 { > > + clocks = <&coreclk 0>; I don't think you need the clocks property. It should be already set in armada-xp.dtsi. > > + adt7473@2e { > > + compatible = "adt7473"; Please include a vendor prefix here. > > + reg = <0x2e>; > > + }; > > + > > + pcf8563@51 { > > + compatible = "pcf8563"; and a vendor prefix here. > > + /* warning: you need both eth1 & 0 to be initialize for poweroff to shutdown otherwise it reboots */ What do you mean by initialized? Driver loaded? Interface up? > This is a great first version I agree with Jason, well done. Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html