From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v2 0/6] Migrate PXA27x platforms to clock framework Date: Mon, 28 Jul 2014 16:55:47 -0700 Message-ID: <20140728235547.4906.20868@quantum> References: <1405353263-13424-1-git-send-email-robert.jarzmik@free.fr> <87k376vadk.fsf@free.fr> <20140726004212.4791.52407@quantum> <87k370o61q.fsf@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87k370o61q.fsf@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Robert Jarzmik Cc: Mark Rutland , devicetree@vger.kernel.org, Eric Miao , Arnd Bergmann , Haojian Zhuang , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Quoting Robert Jarzmik (2014-07-26 01:52:49) > Mike Turquette writes: > > > Quoting Robert Jarzmik (2014-07-21 11:23:51) > >> Robert Jarzmik writes: > >> > >> > This is the second opus of this serie. > >> > >> Ping ? > > > > Hi Robert, > > > > Overall the series looks good to me. The only problem I see is that > > somewhere in the use of the PARENTS() macro there is a section mismatch > > introduced. I spent about 5 minutes looking at it and gave up. This > > problem introduces 26 section mismatch warnings building > > colibri_pxa270_defconfig. > OK Mike, I'll fix this. This is probably because pxa27x_clocks array is not > __init, and it references parents which are __init. I was lazy letting > pxa27x_clocks not __init because I reuse the internal fields "hw" and "gate->hw" > later (hence I didn't leave the __init). > This is a bit dirty and I'll launder it. > > Moreover, I have one fix which I had fixed wrt boot ordering : the > postcore_init() must die. The reason behind is that I have no guarantee of > ordering between clocks init and clocksource init, and clocksource relies on > clocks. > > The right way will be AFAIK to call the core clocks init : > - within the device-tree initialization function : pxa27x_dt_clocks_init() > calls pxa27x_clocks_init9) > - directly from pxa27x_init() or pxa_timer_init() in non-device tree setup > > > Once those are fixed up then I will be happy to take this series. Do you > > want me to take all six patches through the clk tree, including the > > arm/arm stuff? > I would feel more comfortable if : > - you take the 4 first ones (3 clock ones + 1 arm pxa header bit definitions) > - Haojian takes the last 2 ones (pxa ones) > > I will check that taking only the first 4 ones doesn't break anything, in case > there is a merge window hipcup. Sounds good. Regards, Mike > > Cheers. > > -- > Robert