From: "Antoine Ténart" <antoine.tenart@free-electrons.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Antoine Ténart" <antoine.tenart@free-electrons.com>,
sebastian.hesselbarth@gmail.com, kishon@ti.com,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs
Date: Tue, 29 Jul 2014 09:14:47 +0200 [thread overview]
Message-ID: <20140729071447.GA9410@kwain> (raw)
In-Reply-To: <20140728172724.GA7462@htj.dyndns.org>
Hi,
On Mon, Jul 28, 2014 at 01:27:24PM -0400, Tejun Heo wrote:
> On Mon, Jul 28, 2014 at 12:29:56PM +0200, Hans de Goede wrote:
> ...
> > > + if (!enabled_ports) {
> > > + dev_warn(dev, "No port enabled\n");
> > > + return ERR_PTR(-ENODEV);
> >
> > This should be:
> > rc = -ENODEV;
> > goto err_out;
> >
> > Sorry for not catching that sooner.
> >
> > Other then that the entire series looks good and is:
> >
> > Acked-by: Hans de Goede <hdegoede@redhat.com>
>
> Antoine, can you please post an updated version of this patch? No
> need to repost the whole series. Also, how should the series be
> routed?
Sure, I'm doing this right away. Regarding the series, Kishon already
took patches 1-2.
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-29 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 9:17 [PATCH v11 0/8] ARM: berlin: add AHCI support Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 1/8] phy: add a driver for the Berlin SATA PHY Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 2/8] Documentation: bindings: add " Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 3/8] ata: libahci_platform: move port_map parameters into the AHCI structure Antoine Ténart
2014-07-29 14:40 ` Tejun Heo
2014-07-30 8:20 ` Antoine Ténart
2014-07-30 15:35 ` Tejun Heo
2014-07-30 16:47 ` Antoine Ténart
2014-07-30 16:50 ` Tejun Heo
[not found] ` <1406193450-17283-1-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-07-24 9:17 ` [PATCH v11 4/8] ata: libahci: allow to use multiple PHYs Antoine Ténart
2014-07-28 10:29 ` Hans de Goede
2014-07-28 17:27 ` Tejun Heo
2014-07-29 7:14 ` Antoine Ténart [this message]
[not found] ` <1406193450-17283-5-git-send-email-antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-07-30 9:12 ` Kishon Vijay Abraham I
2014-07-24 9:17 ` [PATCH v11 5/8] ata: ahci_platform: add a generic AHCI compatible Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 6/8] Documentation: bindings: document the sub-nodes AHCI bindings Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 7/8] ARM: berlin: add the AHCI node for the BG2Q Antoine Ténart
2014-07-24 9:17 ` [PATCH v11 8/8] ARM: berlin: enable the eSATA interface on the BG2Q DMP Antoine Ténart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729071447.GA9410@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=jszhang@marvell.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tj@kernel.org \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).