From: Thierry Reding <thierry.reding@gmail.com>
To: caesar <caesar.wang@rock-chips.com>
Cc: Doug Anderson <dianders@chromium.org>,
linux-pwm@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] pwm: add this patch to support the new pwm of Rockchip SoCs
Date: Tue, 29 Jul 2014 13:38:10 +0200 [thread overview]
Message-ID: <20140729113808.GC21732@ulmo.nvidia.com> (raw)
In-Reply-To: <53D780D3.8070603@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]
On Tue, Jul 29, 2014 at 07:09:07PM +0800, caesar wrote:
> Thierry,
>
> 在 2014年07月29日 18:22, Thierry Reding 写道:
> >On Mon, Jul 28, 2014 at 07:19:18PM +0800, caesar wrote:
> >>Doug,
> >>在 2014年07月28日 12:01, Doug Anderson 写道:
> >>>Caesar,
> >>>
> >>>On Sun, Jul 27, 2014 at 7:00 AM, caesar <caesar.wang@rock-chips.com> wrote:
> >>>>/*I think will be show the faill log:->
> >>>>
> >>>>* rockchip-pwm ff9301a0.pwm: can't request region for resource [mem
> >>>>0xff9301a0-0xff93019f]
> >>>>*/
> >>>>
> >>>>pc->base = devm_ioremap_resource(dev, regs);
> >>>Did you actually code this up and try it and get this error?
> >>Yeah.
> >This should work if you properly set up the PWM subregion as a child of
> >the LCDC region, which is what MFD will do for you.
> >
> >Thierry
> As you say,should this change be occured by lcdc driver and dts?
>
> The PWM driver don't need do any changes?
No, I don't think the PWM driver needs to be changed for the above to
work.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-29 11:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 12:55 [PATCH v2 0/2] This series adds support for Rockchip SoCs integrated PWM Caesar Wang
2014-07-19 12:55 ` [PATCH v2 1/2] pwm: add this patch to introduce for rk-pwm and vop-pwm Caesar Wang
2014-07-21 8:57 ` Thierry Reding
2014-07-21 10:39 ` caesar
2014-07-19 12:55 ` [PATCH v2 2/2] pwm: add this patch to support the new pwm of Rockchip SoCs Caesar Wang
2014-07-21 8:50 ` Thierry Reding
[not found] ` <53CD0E82.6030901@rock-chips.com>
2014-07-21 13:27 ` Thierry Reding
2014-07-21 14:10 ` caesar
2014-07-25 10:29 ` caesar
2014-07-27 4:59 ` Doug Anderson
[not found] ` <53D50601.1020106@rock-chips.com>
2014-07-28 4:01 ` Doug Anderson
2014-07-28 11:19 ` caesar
[not found] ` <53D631B6.1050603-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-28 16:58 ` Olof Johansson
2014-07-29 9:35 ` caesar
2014-07-29 10:23 ` Thierry Reding
2014-07-29 10:22 ` Thierry Reding
2014-07-29 11:09 ` caesar
2014-07-29 11:38 ` Thierry Reding [this message]
2014-07-29 14:17 ` caesar
2014-07-29 10:25 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140729113808.GC21732@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=caesar.wang@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).