devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Brian Austin <brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH 2/2] Documentation: dt: bindings: sound: Add bindings file for CS35L32
Date: Thu, 31 Jul 2014 21:21:49 +0100	[thread overview]
Message-ID: <20140731202149.GX17528@sirena.org.uk> (raw)
In-Reply-To: <1406664163-10506-2-git-send-email-brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1990 bytes --]

On Tue, Jul 29, 2014 at 03:02:43PM -0500, Brian Austin wrote:

> This patch adds the devicetree bindings file for the Cirrus Logic CS35L32 Boosted Amplifier

Word wrapping in the commit message please.

> +  - cirrus,sdout-datacfg : Data configuration for dual CS35L32 applications only.
> +  Determines the data packed in a two-CS35L32 configuration.
> +  0 = Left/right channels VMON[11:0], IMON[11:0], VPMON[7:0].
> +  1 = Left/right channels VMON[11:0], IMON[11:0], STATUS.
> +  2 = (Default) left/right channels VMON[15:0], IMON [15:0].
> +  3 = Left/right channels VPMON[7:0], STATUS.

> +  - cirrus,sdout-share : SDOUT sharing. Determines whether one or two CS35L32
> +  devices are on board sharing SDOUT.
> +  0 = (Default) One IC.
> +  1 = Two IC's.

So, this was all a bit non-obvious but I found a datasheet so was able
to figure it out.  The device is using the I2S input channels to stream
monitoring data back to the host and can do this in TDM mode.  That's a
bit fun, and would ideally mean we'd have to play with hwmon, but it's
possibly better not to worry about that for now.

Looking at the datasheet I also see a VP supply which is omitted from
the driver and bindings - in battery powered devices like phones it'll
be connected directly to the battery so have no effect but it's still
better to represent it in case someone wants to use it some other way
that does merit software control (eg, a system running off 12V batteries
will need to regulate it down).

> +  - cirrus,gain-manager : Audio-gain management when LEDs are active.
> +  0 = (Default) Automatically reduces audio volume once by 3 dB, only if needed
> +  to avoid thermal shutdown or current limiting the boost converter.
> +  If the condition persists, the CS35L32 examine s ILED_MNG and responds accordingly.
> +  Audio recovers to original volume automatically at the end of the LED event.
> +  1 = User controls volume (nonautomatic).

This looks like something that should be a runtime control.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2014-07-31 20:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 20:02 [PATCH 1/2] ASoC: Add support for CS35L32 Boosted Amplifier Brian Austin
2014-07-30 21:02 ` Dinh Nguyen
2014-07-31 14:37   ` Brian Austin
     [not found] ` <1406664163-10506-1-git-send-email-brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
2014-07-29 20:02   ` [PATCH 2/2] Documentation: dt: bindings: sound: Add bindings file for CS35L32 Brian Austin
     [not found]     ` <1406664163-10506-2-git-send-email-brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
2014-07-31 20:21       ` Mark Brown [this message]
     [not found]         ` <20140731202149.GX17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-07-31 20:40           ` Brian Austin
2014-07-31 21:18             ` Mark Brown
     [not found]               ` <20140731211828.GA17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-07-31 21:28                 ` Brian Austin
2014-07-31 20:07   ` [PATCH 1/2] ASoC: Add support for CS35L32 Boosted Amplifier Mark Brown
     [not found]     ` <20140731200729.GW17528-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-07-31 20:27       ` Brian Austin
2014-07-31 20:27         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731202149.GX17528@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).