* [PATCH 1/3] arm: dts: omap3-gta04: Rename gta04.dts to gta04.dtsi and add a4 model
2014-07-28 19:53 [PATCH 0/3] arm: dts: omap3-gta04: Move common parts to include file and add models Marek Belisko
@ 2014-07-28 19:53 ` Marek Belisko
2014-07-28 19:53 ` [PATCH 2/3] arm: dts: Add gta04a3 model Marek Belisko
2014-07-28 19:53 ` [PATCH 3/3] arm: dts: Add gta04a5 model Marek Belisko
2 siblings, 0 replies; 16+ messages in thread
From: Marek Belisko @ 2014-07-28 19:53 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
bcousson, tony
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-omap, hns,
Marek Belisko
This patch is preparation of adding more boards which have common moved
to omap3-gta04.dtsi. Other boards have only small additions to omap3-gta04a4.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
arch/arm/boot/dts/Makefile | 2 +-
arch/arm/boot/dts/{omap3-gta04.dts => omap3-gta04.dtsi} | 0
arch/arm/boot/dts/omap3-gta04a4.dts | 13 +++++++++++++
3 files changed, 14 insertions(+), 1 deletion(-)
rename arch/arm/boot/dts/{omap3-gta04.dts => omap3-gta04.dtsi} (100%)
create mode 100644 arch/arm/boot/dts/omap3-gta04a4.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 82f498b..3dc9d44 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -283,7 +283,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
omap3-devkit8000.dtb \
omap3-evm.dtb \
omap3-evm-37xx.dtb \
- omap3-gta04.dtb \
+ omap3-gta04a4.dtb \
omap3-igep0020.dtb \
omap3-igep0030.dtb \
omap3-ldp.dtb \
diff --git a/arch/arm/boot/dts/omap3-gta04.dts b/arch/arm/boot/dts/omap3-gta04.dtsi
similarity index 100%
rename from arch/arm/boot/dts/omap3-gta04.dts
rename to arch/arm/boot/dts/omap3-gta04.dtsi
diff --git a/arch/arm/boot/dts/omap3-gta04a4.dts b/arch/arm/boot/dts/omap3-gta04a4.dts
new file mode 100644
index 0000000..c918bb1
--- /dev/null
+++ b/arch/arm/boot/dts/omap3-gta04a4.dts
@@ -0,0 +1,13 @@
+/*
+ * Copyright (C) 2014 Marek Belisko <marek@goldelico.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-gta04.dtsi"
+
+/ {
+ model = "Goldelico GTA04A4";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 2/3] arm: dts: Add gta04a3 model
2014-07-28 19:53 [PATCH 0/3] arm: dts: omap3-gta04: Move common parts to include file and add models Marek Belisko
2014-07-28 19:53 ` [PATCH 1/3] arm: dts: omap3-gta04: Rename gta04.dts to gta04.dtsi and add a4 model Marek Belisko
@ 2014-07-28 19:53 ` Marek Belisko
2014-07-28 19:53 ` [PATCH 3/3] arm: dts: Add gta04a5 model Marek Belisko
2 siblings, 0 replies; 16+ messages in thread
From: Marek Belisko @ 2014-07-28 19:53 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
bcousson, tony
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-omap, hns,
Marek Belisko
Add gta04a3 model with additional acceleromer.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/omap3-gta04a3.dts | 48 +++++++++++++++++++++++++++++++++++++
2 files changed, 49 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3-gta04a3.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 3dc9d44..7d45fde 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -283,6 +283,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
omap3-devkit8000.dtb \
omap3-evm.dtb \
omap3-evm-37xx.dtb \
+ omap3-gta04a3.dtb \
omap3-gta04a4.dtb \
omap3-igep0020.dtb \
omap3-igep0030.dtb \
diff --git a/arch/arm/boot/dts/omap3-gta04a3.dts b/arch/arm/boot/dts/omap3-gta04a3.dts
new file mode 100644
index 0000000..3099a89
--- /dev/null
+++ b/arch/arm/boot/dts/omap3-gta04a3.dts
@@ -0,0 +1,48 @@
+/*
+ * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-gta04.dtsi"
+
+/ {
+ model = "Goldelico GTA04A3";
+};
+
+&i2c2 {
+
+ /* alternate accelerometer that might be installed on some GTA04A3 boards */
+ lis302@1d {
+ compatible = "st,lis331dlh", "st,lis3lv02d";
+ reg = <0x1d>;
+ interrupt-parent = <&gpio3>;
+ interrupts = <18 (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_EDGE_RISING)>;
+ Vdd-supply = <&vaux2>;
+ Vdd_IO-supply = <&vaux2>;
+
+ st,click-single-x;
+ st,click-single-y;
+ st,click-single-z;
+ st,click-thresh-x = <8>;
+ st,click-thresh-y = <8>;
+ st,click-thresh-z = <10>;
+ st,click-click-time-limit = <9>;
+ st,click-latency = <50>;
+ st,irq1-click;
+ st,wakeup-x-lo;
+ st,wakeup-x-hi;
+ st,wakeup-y-lo;
+ st,wakeup-y-hi;
+ st,wakeup-z-lo;
+ st,wakeup-z-hi;
+ st,min-limit-x = <32>;
+ st,min-limit-y = <3>;
+ st,min-limit-z = <3>;
+ st,max-limit-x = <3>;
+ st,max-limit-y = <32>;
+ st,max-limit-z = <32>;
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 19:53 [PATCH 0/3] arm: dts: omap3-gta04: Move common parts to include file and add models Marek Belisko
2014-07-28 19:53 ` [PATCH 1/3] arm: dts: omap3-gta04: Rename gta04.dts to gta04.dtsi and add a4 model Marek Belisko
2014-07-28 19:53 ` [PATCH 2/3] arm: dts: Add gta04a3 model Marek Belisko
@ 2014-07-28 19:53 ` Marek Belisko
2014-07-28 19:56 ` Michael Trimarchi
2 siblings, 1 reply; 16+ messages in thread
From: Marek Belisko @ 2014-07-28 19:53 UTC (permalink / raw)
To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
bcousson, tony
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-omap, hns,
Marek Belisko
Add model a5 which have additional jack detection.
Signed-off-by: Marek Belisko <marek@goldelico.com>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
2 files changed, 18 insertions(+)
create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 7d45fde..576c595 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
omap3-evm-37xx.dtb \
omap3-gta04a3.dtb \
omap3-gta04a4.dtb \
+ omap3-gta04a5.dtb \
omap3-igep0020.dtb \
omap3-igep0030.dtb \
omap3-ldp.dtb \
diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
new file mode 100644
index 0000000..210317c3
--- /dev/null
+++ b/arch/arm/boot/dts/omap3-gta04a5.dts
@@ -0,0 +1,17 @@
+/*
+ * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-gta04.dtsi"
+
+/ {
+ model = "Goldelico GTA04A5;
+
+ sound {
+ ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only */
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 19:53 ` [PATCH 3/3] arm: dts: Add gta04a5 model Marek Belisko
@ 2014-07-28 19:56 ` Michael Trimarchi
2014-07-28 20:02 ` Belisko Marek
0 siblings, 1 reply; 16+ messages in thread
From: Michael Trimarchi @ 2014-07-28 19:56 UTC (permalink / raw)
To: Marek Belisko
Cc: hns, galak, bcousson, mark.rutland, robh+dt, tony, linux-kernel,
linux, ijc+devicetree, linux-arm-kernel, pawel.moll, linux-omap,
devicetree
[-- Attachment #1: Type: text/plain, Size: 1840 bytes --]
Hi Marek
Il 28/lug/2014 21:54 "Marek Belisko" <marek@goldelico.com> ha scritto:
>
> Add model a5 which have additional jack detection.
>
> Signed-off-by: Marek Belisko <marek@goldelico.com>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
> 2 files changed, 18 insertions(+)
> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7d45fde..576c595 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
> omap3-evm-37xx.dtb \
> omap3-gta04a3.dtb \
> omap3-gta04a4.dtb \
> + omap3-gta04a5.dtb \
> omap3-igep0020.dtb \
> omap3-igep0030.dtb \
> omap3-ldp.dtb \
> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
b/arch/arm/boot/dts/omap3-gta04a5.dts
> new file mode 100644
> index 0000000..210317c3
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> @@ -0,0 +1,17 @@
> +/*
> + * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include "omap3-gta04.dtsi"
> +
> +/ {
> + model = "Goldelico GTA04A5;
> +
> + sound {
> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only */
> + };
> +};
> --
> 1.9.1
>
Can we have only one dts with status enabled/disabled?
Michael
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Type: text/html, Size: 2687 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 19:56 ` Michael Trimarchi
@ 2014-07-28 20:02 ` Belisko Marek
2014-07-28 20:04 ` Michael Trimarchi
0 siblings, 1 reply; 16+ messages in thread
From: Belisko Marek @ 2014-07-28 20:02 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Dr. H. Nikolaus Schaller, Kumar Gala, Benoit Cousson,
Mark Rutland, Rob Herring, Tony Lindgren, LKML,
Russell King - ARM Linux, ijc+devicetree@hellion.org.uk,
linux-arm-kernel, Pawel Moll, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org
Hi Michael,
On Mon, Jul 28, 2014 at 9:56 PM, Michael Trimarchi
<michael@amarulasolutions.com> wrote:
> Hi Marek
>
> Il 28/lug/2014 21:54 "Marek Belisko" <marek@goldelico.com> ha scritto:
>
>
>>
>> Add model a5 which have additional jack detection.
>>
>> Signed-off-by: Marek Belisko <marek@goldelico.com>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
>> 2 files changed, 18 insertions(+)
>> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 7d45fde..576c595 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
>> omap3-evm-37xx.dtb \
>> omap3-gta04a3.dtb \
>> omap3-gta04a4.dtb \
>> + omap3-gta04a5.dtb \
>> omap3-igep0020.dtb \
>> omap3-igep0030.dtb \
>> omap3-ldp.dtb \
>> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
>> b/arch/arm/boot/dts/omap3-gta04a5.dts
>> new file mode 100644
>> index 0000000..210317c3
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
>> @@ -0,0 +1,17 @@
>> +/*
>> + * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include "omap3-gta04.dtsi"
>> +
>> +/ {
>> + model = "Goldelico GTA04A5;
>> +
>> + sound {
>> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only */
>> + };
>> +};
>> --
>> 1.9.1
>>
>
> Can we have only one dts with status enabled/disabled?
Do you mean to define this node it gta04.dtsi disabled and enable only
for a5 model?
>
> Michael
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 20:02 ` Belisko Marek
@ 2014-07-28 20:04 ` Michael Trimarchi
[not found] ` <CAOf5uw=Fm9FXEH5ESqDC8pGjMbn5VQ1+MyPJVXSqGh_9+JRLHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Michael Trimarchi @ 2014-07-28 20:04 UTC (permalink / raw)
To: Marek Belisko
Cc: pawel.moll, Kumar Gala, Mark Rutland, Benoit Cousson,
Dr. H. Nikolaus Schaller, linux-omap@vger.kernel.org,
linux-arm-kernel, ijc+devicetree@hellion.org.uk, Tony Lindgren,
Rob Herring, Russell King - ARM Linux, LKML,
devicetree@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 2696 bytes --]
Hi
Il 28/lug/2014 22:02 "Belisko Marek" <marek.belisko@gmail.com> ha scritto:
>
> Hi Michael,
>
> On Mon, Jul 28, 2014 at 9:56 PM, Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> > Hi Marek
> >
> > Il 28/lug/2014 21:54 "Marek Belisko" <marek@goldelico.com> ha scritto:
> >
> >
> >>
> >> Add model a5 which have additional jack detection.
> >>
> >> Signed-off-by: Marek Belisko <marek@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/Makefile | 1 +
> >> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
> >> 2 files changed, 18 insertions(+)
> >> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
> >>
> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> index 7d45fde..576c595 100644
> >> --- a/arch/arm/boot/dts/Makefile
> >> +++ b/arch/arm/boot/dts/Makefile
> >> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
> >> omap3-evm-37xx.dtb \
> >> omap3-gta04a3.dtb \
> >> omap3-gta04a4.dtb \
> >> + omap3-gta04a5.dtb \
> >> omap3-igep0020.dtb \
> >> omap3-igep0030.dtb \
> >> omap3-ldp.dtb \
> >> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
> >> b/arch/arm/boot/dts/omap3-gta04a5.dts
> >> new file mode 100644
> >> index 0000000..210317c3
> >> --- /dev/null
> >> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> >> @@ -0,0 +1,17 @@
> >> +/*
> >> + * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
> >> + *
> >> + * This program is free software; you can redistribute it and/or
modify
> >> + * it under the terms of the GNU General Public License version 2 as
> >> + * published by the Free Software Foundation.
> >> + */
> >> +
> >> +#include "omap3-gta04.dtsi"
> >> +
> >> +/ {
> >> + model = "Goldelico GTA04A5;
> >> +
> >> + sound {
> >> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only
*/
> >> + };
> >> +};
> >> --
> >> 1.9.1
> >>
> >
> > Can we have only one dts with status enabled/disabled?
> Do you mean to define this node it gta04.dtsi disabled and enable only
> for a5 model?
> >
This should be possible in the bootloader
Right?
Michael
> > Michael
> >
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-omap"
in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> BR,
>
> marek
>
> --
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
>
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com
[-- Attachment #2: Type: text/html, Size: 4334 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread[parent not found: <CAOf5uw=Fm9FXEH5ESqDC8pGjMbn5VQ1+MyPJVXSqGh_9+JRLHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
[not found] ` <CAOf5uw=Fm9FXEH5ESqDC8pGjMbn5VQ1+MyPJVXSqGh_9+JRLHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-07-28 20:06 ` Belisko Marek
2014-07-28 20:12 ` Michael Trimarchi
0 siblings, 1 reply; 16+ messages in thread
From: Belisko Marek @ 2014-07-28 20:06 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Pawel Moll, Kumar Gala, Mark Rutland, Benoit Cousson,
Dr. H. Nikolaus Schaller,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
Tony Lindgren, Rob Herring, Russell King - ARM Linux, LKML,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On Mon, Jul 28, 2014 at 10:04 PM, Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> wrote:
> Hi
>
> Il 28/lug/2014 22:02 "Belisko Marek" <marek.belisko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ha scritto:
>
>
>>
>> Hi Michael,
>>
>> On Mon, Jul 28, 2014 at 9:56 PM, Michael Trimarchi
>> <michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org> wrote:
>> > Hi Marek
>> >
>> > Il 28/lug/2014 21:54 "Marek Belisko" <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org> ha scritto:
>> >
>> >
>> >>
>> >> Add model a5 which have additional jack detection.
>> >>
>> >> Signed-off-by: Marek Belisko <marek-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
>> >> ---
>> >> arch/arm/boot/dts/Makefile | 1 +
>> >> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
>> >> 2 files changed, 18 insertions(+)
>> >> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
>> >>
>> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> >> index 7d45fde..576c595 100644
>> >> --- a/arch/arm/boot/dts/Makefile
>> >> +++ b/arch/arm/boot/dts/Makefile
>> >> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
>> >> omap3-evm-37xx.dtb \
>> >> omap3-gta04a3.dtb \
>> >> omap3-gta04a4.dtb \
>> >> + omap3-gta04a5.dtb \
>> >> omap3-igep0020.dtb \
>> >> omap3-igep0030.dtb \
>> >> omap3-ldp.dtb \
>> >> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
>> >> b/arch/arm/boot/dts/omap3-gta04a5.dts
>> >> new file mode 100644
>> >> index 0000000..210317c3
>> >> --- /dev/null
>> >> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
>> >> @@ -0,0 +1,17 @@
>> >> +/*
>> >> + * Copyright (C) 2014 H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
>> >> + *
>> >> + * This program is free software; you can redistribute it and/or
>> >> modify
>> >> + * it under the terms of the GNU General Public License version 2 as
>> >> + * published by the Free Software Foundation.
>> >> + */
>> >> +
>> >> +#include "omap3-gta04.dtsi"
>> >> +
>> >> +/ {
>> >> + model = "Goldelico GTA04A5;
>> >> +
>> >> + sound {
>> >> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only
>> >> */
>> >> + };
>> >> +};
>> >> --
>> >> 1.9.1
>> >>
>> >
>> > Can we have only one dts with status enabled/disabled?
>> Do you mean to define this node it gta04.dtsi disabled and enable only
>> for a5 model?
>> >
>
> This should be possible in the bootloader
Sorry I didn't get that. Can you give me some short example (or
existing board which using it)?
Thanks.
>
> Right?
>
> Michael
>
>> > Michael
>> >
>> >> --
>> >> To unsubscribe from this list: send the line "unsubscribe linux-omap"
>> >> in
>> >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>> BR,
>>
>> marek
>>
>> --
>> as simple and primitive as possible
>> -------------------------------------------------
>> Marek Belisko - OPEN-NANDRA
>> Freelance Developer
>>
>> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
>> Tel: +421 915 052 184
>> skype: marekwhite
>> twitter: #opennandra
>> web: http://open-nandra.com
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 20:06 ` Belisko Marek
@ 2014-07-28 20:12 ` Michael Trimarchi
[not found] ` <CAOf5uwmjznuK_1au1HnsnYh=BhqC=x+O_tpk6U71bqPv=hFe_A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 16+ messages in thread
From: Michael Trimarchi @ 2014-07-28 20:12 UTC (permalink / raw)
To: Marek Belisko
Cc: Kumar Gala, pawel.moll, Benoit Cousson, Mark Rutland,
Dr. H. Nikolaus Schaller, linux-omap@vger.kernel.org,
Tony Lindgren, ijc+devicetree@hellion.org.uk, linux-arm-kernel,
Rob Herring, LKML, Russell King - ARM Linux,
devicetree@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 3865 bytes --]
Hi
Il 28/lug/2014 22:06 "Belisko Marek" <marek.belisko@gmail.com> ha scritto:
>
> On Mon, Jul 28, 2014 at 10:04 PM, Michael Trimarchi
> <michael@amarulasolutions.com> wrote:
> > Hi
> >
> > Il 28/lug/2014 22:02 "Belisko Marek" <marek.belisko@gmail.com> ha
scritto:
> >
> >
> >>
> >> Hi Michael,
> >>
> >> On Mon, Jul 28, 2014 at 9:56 PM, Michael Trimarchi
> >> <michael@amarulasolutions.com> wrote:
> >> > Hi Marek
> >> >
> >> > Il 28/lug/2014 21:54 "Marek Belisko" <marek@goldelico.com> ha
scritto:
> >> >
> >> >
> >> >>
> >> >> Add model a5 which have additional jack detection.
> >> >>
> >> >> Signed-off-by: Marek Belisko <marek@goldelico.com>
> >> >> ---
> >> >> arch/arm/boot/dts/Makefile | 1 +
> >> >> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
> >> >> 2 files changed, 18 insertions(+)
> >> >> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
> >> >>
> >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> >> >> index 7d45fde..576c595 100644
> >> >> --- a/arch/arm/boot/dts/Makefile
> >> >> +++ b/arch/arm/boot/dts/Makefile
> >> >> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) +=
am3517-craneboard.dtb \
> >> >> omap3-evm-37xx.dtb \
> >> >> omap3-gta04a3.dtb \
> >> >> omap3-gta04a4.dtb \
> >> >> + omap3-gta04a5.dtb \
> >> >> omap3-igep0020.dtb \
> >> >> omap3-igep0030.dtb \
> >> >> omap3-ldp.dtb \
> >> >> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
> >> >> b/arch/arm/boot/dts/omap3-gta04a5.dts
> >> >> new file mode 100644
> >> >> index 0000000..210317c3
> >> >> --- /dev/null
> >> >> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> >> >> @@ -0,0 +1,17 @@
> >> >> +/*
> >> >> + * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
> >> >> + *
> >> >> + * This program is free software; you can redistribute it and/or
> >> >> modify
> >> >> + * it under the terms of the GNU General Public License version 2
as
> >> >> + * published by the Free Software Foundation.
> >> >> + */
> >> >> +
> >> >> +#include "omap3-gta04.dtsi"
> >> >> +
> >> >> +/ {
> >> >> + model = "Goldelico GTA04A5;
> >> >> +
> >> >> + sound {
> >> >> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5
only
> >> >> */
> >> >> + };
> >> >> +};
> >> >> --
> >> >> 1.9.1
> >> >>
> >> >
> >> > Can we have only one dts with status enabled/disabled?
> >> Do you mean to define this node it gta04.dtsi disabled and enable only
> >> for a5 model?
> >> >
> >
> > This should be possible in the bootloader
> Sorry I didn't get that. Can you give me some short example (or
> existing board which using it)?
> Thanks.
> >
http://www.denx.de/wiki/view/DULG/UBootCmdFDT
I just suggest to not create a dts for each board revision but let it
manage by the bootloader. I don't know if there are examples but make sense
to me to avoid to add a lot of dts.
Michael
> > Right?
> >
> > Michael
> >
> >> > Michael
> >> >
> >> >> --
> >> >> To unsubscribe from this list: send the line "unsubscribe
linux-omap"
> >> >> in
> >> >> the body of a message to majordomo@vger.kernel.org
> >> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
> >> BR,
> >>
> >> marek
> >>
> >> --
> >> as simple and primitive as possible
> >> -------------------------------------------------
> >> Marek Belisko - OPEN-NANDRA
> >> Freelance Developer
> >>
> >> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> >> Tel: +421 915 052 184
> >> skype: marekwhite
> >> twitter: #opennandra
> >> web: http://open-nandra.com
>
> BR,
>
> marek
>
> --
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
>
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> twitter: #opennandra
> web: http://open-nandra.com
[-- Attachment #2: Type: text/html, Size: 6613 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 20:04 ` Michael Trimarchi
[not found] ` <CAOf5uw=Fm9FXEH5ESqDC8pGjMbn5VQ1+MyPJVXSqGh_9+JRLHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-07-28 20:12 ` Dr. H. Nikolaus Schaller
2014-07-28 20:42 ` Dr. H. Nikolaus Schaller
2 siblings, 0 replies; 16+ messages in thread
From: Dr. H. Nikolaus Schaller @ 2014-07-28 20:12 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Marek Belisko, pawel.moll, Kumar Gala, Mark Rutland,
Benoit Cousson, linux-omap@vger.kernel.org, linux-arm-kernel,
ijc+devicetree@hellion.org.uk, Tony Lindgren, Rob Herring,
Russell King - ARM Linux, LKML, devicetree@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 2975 bytes --]
Am 28.07.2014 um 22:04 schrieb Michael Trimarchi:
> Hi
>
> Il 28/lug/2014 22:02 "Belisko Marek" <marek.belisko@gmail.com> ha scritto:
> >
> > Hi Michael,
> >
> > On Mon, Jul 28, 2014 at 9:56 PM, Michael Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > > Hi Marek
> > >
> > > Il 28/lug/2014 21:54 "Marek Belisko" <marek@goldelico.com> ha scritto:
> > >
> > >
> > >>
> > >> Add model a5 which have additional jack detection.
> > >>
> > >> Signed-off-by: Marek Belisko <marek@goldelico.com>
> > >> ---
> > >> arch/arm/boot/dts/Makefile | 1 +
> > >> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
> > >> 2 files changed, 18 insertions(+)
> > >> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
> > >>
> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > >> index 7d45fde..576c595 100644
> > >> --- a/arch/arm/boot/dts/Makefile
> > >> +++ b/arch/arm/boot/dts/Makefile
> > >> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
> > >> omap3-evm-37xx.dtb \
> > >> omap3-gta04a3.dtb \
> > >> omap3-gta04a4.dtb \
> > >> + omap3-gta04a5.dtb \
> > >> omap3-igep0020.dtb \
> > >> omap3-igep0030.dtb \
> > >> omap3-ldp.dtb \
> > >> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
> > >> b/arch/arm/boot/dts/omap3-gta04a5.dts
> > >> new file mode 100644
> > >> index 0000000..210317c3
> > >> --- /dev/null
> > >> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> > >> @@ -0,0 +1,17 @@
> > >> +/*
> > >> + * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
> > >> + *
> > >> + * This program is free software; you can redistribute it and/or modify
> > >> + * it under the terms of the GNU General Public License version 2 as
> > >> + * published by the Free Software Foundation.
> > >> + */
> > >> +
> > >> +#include "omap3-gta04.dtsi"
> > >> +
> > >> +/ {
> > >> + model = "Goldelico GTA04A5;
> > >> +
> > >> + sound {
> > >> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only */
> > >> + };
> > >> +};
> > >> --
> > >> 1.9.1
> > >>
> > >
> > > Can we have only one dts with status enabled/disabled?
> > Do you mean to define this node it gta04.dtsi disabled and enable only
> > for a5 model?
> > >
>
> This should be possible in the bootloader
>
Yes,
the boot loader either loads gta04a3.dtb gta04.dtb or gta05.dtb
depending on board revision.
Therefore we have multiple device tree files to represent such hardware
differences. Like Gumstix Overo variants (using a omap3-overo-base.dtsi)
And, this difference is not the only one. Other are to come later.
Unfortunately we were recommend to submit only DT nodes that already
have drivers. Therefore, the "big picture" of the device variants support
may not yet be visible from this patch.
I hope this gives a little background.
BR,
Nikolaus
[-- Attachment #2: Type: text/html, Size: 4755 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PATCH 3/3] arm: dts: Add gta04a5 model
2014-07-28 20:04 ` Michael Trimarchi
[not found] ` <CAOf5uw=Fm9FXEH5ESqDC8pGjMbn5VQ1+MyPJVXSqGh_9+JRLHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-28 20:12 ` Dr. H. Nikolaus Schaller
@ 2014-07-28 20:42 ` Dr. H. Nikolaus Schaller
[not found] ` <1FA8171E-1B7A-4684-887E-11593BB9C29E-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2 siblings, 1 reply; 16+ messages in thread
From: Dr. H. Nikolaus Schaller @ 2014-07-28 20:42 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Mark Rutland, devicetree@vger.kernel.org,
Russell King - ARM Linux, pawel.moll,
ijc+devicetree@hellion.org.uk, Tony Lindgren, Marek Belisko, LKML,
Rob Herring, Benoit Cousson, Kumar Gala,
linux-omap@vger.kernel.org, linux-arm-kernel
Am 28.07.2014 um 22:04 schrieb Michael Trimarchi:
> Hi
>
> Il 28/lug/2014 22:02 "Belisko Marek" <marek.belisko@gmail.com> ha scritto:
> >
> > Hi Michael,
> >
> > On Mon, Jul 28, 2014 at 9:56 PM, Michael Trimarchi
> > <michael@amarulasolutions.com> wrote:
> > > Hi Marek
> > >
> > > Il 28/lug/2014 21:54 "Marek Belisko" <marek@goldelico.com> ha scritto:
> > >
> > >
> > >>
> > >> Add model a5 which have additional jack detection.
> > >>
> > >> Signed-off-by: Marek Belisko <marek@goldelico.com>
> > >> ---
> > >> arch/arm/boot/dts/Makefile | 1 +
> > >> arch/arm/boot/dts/omap3-gta04a5.dts | 17 +++++++++++++++++
> > >> 2 files changed, 18 insertions(+)
> > >> create mode 100644 arch/arm/boot/dts/omap3-gta04a5.dts
> > >>
> > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > >> index 7d45fde..576c595 100644
> > >> --- a/arch/arm/boot/dts/Makefile
> > >> +++ b/arch/arm/boot/dts/Makefile
> > >> @@ -285,6 +285,7 @@ dtb-$(CONFIG_ARCH_OMAP3) += am3517-craneboard.dtb \
> > >> omap3-evm-37xx.dtb \
> > >> omap3-gta04a3.dtb \
> > >> omap3-gta04a4.dtb \
> > >> + omap3-gta04a5.dtb \
> > >> omap3-igep0020.dtb \
> > >> omap3-igep0030.dtb \
> > >> omap3-ldp.dtb \
> > >> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts
> > >> b/arch/arm/boot/dts/omap3-gta04a5.dts
> > >> new file mode 100644
> > >> index 0000000..210317c3
> > >> --- /dev/null
> > >> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> > >> @@ -0,0 +1,17 @@
> > >> +/*
> > >> + * Copyright (C) 2014 H. Nikolaus Schaller <hns@goldelico.com>
> > >> + *
> > >> + * This program is free software; you can redistribute it and/or modify
> > >> + * it under the terms of the GNU General Public License version 2 as
> > >> + * published by the Free Software Foundation.
> > >> + */
> > >> +
> > >> +#include "omap3-gta04.dtsi"
> > >> +
> > >> +/ {
> > >> + model = "Goldelico GTA04A5;
> > >> +
> > >> + sound {
> > >> + ti,jack-det-gpio = <&twl_gpio 2 0>; /* GTA04A5 only */
> > >> + };
> > >> +};
> > >> --
> > >> 1.9.1
> > >>
> > >
> > > Can we have only one dts with status enabled/disabled?
> > Do you mean to define this node it gta04.dtsi disabled and enable only
> > for a5 model?
> > >
>
> This should be possible in the bootloader
>
Yes,
the boot loader either loads gta04a3.dtb gta04.dtb or gta05.dtb
depending on board revision.
Therefore we have multiple device tree files to represent such hardware
differences. Like Gumstix Overo variants (using a omap3-overo-base.dtsi)
And, this difference is not the only one. Other are to come later.
Unfortunately we were recommend to submit only DT nodes that already
have drivers. Therefore, the "big picture" of the device variants support
may not yet be visible from this patch.
I hope this gives a little background.
BR,
Nikolaus
^ permalink raw reply [flat|nested] 16+ messages in thread