From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: "Alan Cox" <alan@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
jslaby@suse.cz, "Grant Likely" <grant.likely@linaro.org>,
"Varka Bhadram" <varkabhadram@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Yingjoe Chen" <yingjoe.chen@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver
Date: Thu, 7 Aug 2014 19:35:12 +0100 [thread overview]
Message-ID: <20140807193512.1825b291@alan.etchedpixels.co.uk> (raw)
In-Reply-To: <CABuKBeKJ=KFc1DfvyHgD+iAC1=yLqYjjDUc0CH+1zbRQzw_DJw@mail.gmail.com>
On Thu, 7 Aug 2014 16:07:41 +0200
Matthias Brugger <matthias.bgg@gmail.com> wrote:
> 2014-08-07 15:21 GMT+02:00 Alan Cox <alan@linux.intel.com>:
> >
> >> + * Some baudrates are not supported by the chip, so we use the next
> >> + * lower rate supported and update termios c_flag.
> >
> > I don't see the termios updating being done now ?
>
> Please have a look on the usage of the SET_CFLAG_BAUD macro in the patch.
> I'm not sure if it is the way to go though.
Ah missed that - no it's not the right way to go. From
8250_core:serial8250_do_set_termios() do
/* Don't rewrite B0 */
if (tty_termios_baud_rate(termios))
tty_termios_encode_baud_rate(termios, baud, baud);
which will encoding the baud rate correctly for all cases, and where
possible encode it in the old style format rather than using BOTHER
(which old old apps cannot handle)
Alan
next prev parent reply other threads:[~2014-08-07 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 6:51 [PATCH v2 0/2] tty: serial: Add mediatek UART driver Matthias Brugger
2014-08-07 6:51 ` [PATCH v2 1/2] tty: serial: 8250: Add Mediatek " Matthias Brugger
[not found] ` <1407394292-26317-2-git-send-email-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-07 13:21 ` Alan Cox
2014-08-07 14:07 ` Matthias Brugger
2014-08-07 18:35 ` One Thousand Gnomes [this message]
[not found] ` <1407394292-26317-1-git-send-email-matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-08-07 6:51 ` [PATCH v2 2/2] DTS: serial: Add bindings documention for the Mediatek UARTs Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140807193512.1825b291@alan.etchedpixels.co.uk \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jslaby@suse.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=varkabhadram@gmail.com \
--cc=yingjoe.chen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).