From mboxrd@z Thu Jan 1 00:00:00 1970 From: One Thousand Gnomes Subject: Re: [PATCH v2 1/2] tty: serial: 8250: Add Mediatek UART driver Date: Thu, 7 Aug 2014 19:35:12 +0100 Message-ID: <20140807193512.1825b291@alan.etchedpixels.co.uk> References: <1407394292-26317-1-git-send-email-matthias.bgg@gmail.com> <1407394292-26317-2-git-send-email-matthias.bgg@gmail.com> <1407417714.8334.8.camel@acox1-desk.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Matthias Brugger Cc: Alan Cox , "linux-kernel@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Greg KH , jslaby@suse.cz, Grant Likely , Varka Bhadram , Heiko =?UTF-8?B?U3TDvGJuZXI=?= , Yingjoe Chen , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , linux-serial@vger.kernel.org List-Id: devicetree@vger.kernel.org On Thu, 7 Aug 2014 16:07:41 +0200 Matthias Brugger wrote: > 2014-08-07 15:21 GMT+02:00 Alan Cox : > > > >> + * Some baudrates are not supported by the chip, so we use the next > >> + * lower rate supported and update termios c_flag. > > > > I don't see the termios updating being done now ? > > Please have a look on the usage of the SET_CFLAG_BAUD macro in the patch. > I'm not sure if it is the way to go though. Ah missed that - no it's not the right way to go. From 8250_core:serial8250_do_set_termios() do /* Don't rewrite B0 */ if (tty_termios_baud_rate(termios)) tty_termios_encode_baud_rate(termios, baud, baud); which will encoding the baud rate correctly for all cases, and where possible encode it in the old style format rather than using BOTHER (which old old apps cannot handle) Alan