From: Pavel Machek <pavel@denx.de>
To: Alan Tull <delicious.quinoa@gmail.com>
Cc: Pavel Machek <pavel@denx.de>,
atull@opensource.altera.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"H. Peter Anvin" <hpa@zytor.com>, Michal Simek <monstr@monstr.eu>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Rob Herring <robh+dt@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Mark Brown <broonie@kernel.org>,
Philip Balister <philip@balister.org>,
Alessandro Rubini <rubini@gnudd.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Kyle Teske <kyle.teske@ni.com>, Nicolas Pitre <nico@linaro.org>,
Felipe Balbi <balbi@ti.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
David Brown <davidb@codeaurora.org>,
Rob Landley <rob@landley.net>,
"David S. Miller" <davem@davemloft.net>,
Cesar Eduardo Barros <cesarb@cesarb.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
dinguyen@opensource.altera.com, yvanderv@opensource.altera.com
Subject: Re: [PATCH 1/3] fpga manager framework core
Date: Sat, 9 Aug 2014 16:50:24 +0200 [thread overview]
Message-ID: <20140809145024.GA6764@pollux.denx.de> (raw)
In-Reply-To: <CANk1AXTAMCo_0c2+B9_6AbPPPof=rHZnE+NyxipzVYFnNuS2LQ@mail.gmail.com>
On Tue 2014-08-05 15:05:40, Alan Tull wrote:
> On Fri, Aug 1, 2014 at 7:18 PM, Pavel Machek <pavel@denx.de> wrote:
> > Hi!
> >
> >> + nr = ida_simple_get(&fpga_mgr_ida, start, FPGA_MAX_MINORS, GFP_KERNEL);
> >> +
> >
> > Actually, are you sure ida framework is a good idea here? AFAICT, you
> > only use it to keep track of used minors.
> > pavel
> >
>
> Yes, the ida is to keep track of minors. I think that was the intent
> of introducing ida into the kernel (looking at git logs of idr.c).
> SImilar to idr, but uses less memory. I see some other frameworks
> using it for this purpose, such as the rtc class. I can change this
> if this is something the kernel wants to move away from. What issues
> are you seeing here and what would you suggest?
Well, it looked to me like a job for bitfield, since we don't plan that many
minors...
Pavel
next prev parent reply other threads:[~2014-08-09 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 22:28 [PATCH 0/3] Yet another stab at a fpga framework atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
2014-08-01 22:28 ` [PATCH 1/3] fpga manager framework core atull
2014-08-02 0:15 ` Pavel Machek
2014-08-05 18:11 ` Alan Tull
[not found] ` <1406932118-13885-2-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-08-02 0:18 ` Pavel Machek
2014-08-05 20:05 ` Alan Tull
2014-08-09 14:50 ` Pavel Machek [this message]
2014-08-09 15:49 ` Greg Kroah-Hartman
[not found] ` <1406932118-13885-1-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-08-01 22:28 ` [PATCH 2/3] fpga bus driver atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx
[not found] ` <1406932118-13885-3-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-08-02 0:23 ` Pavel Machek
2014-08-05 17:11 ` Alan Tull
2014-08-05 18:21 ` Pantelis Antoniou
2014-08-01 22:28 ` [PATCH 3/3] fpga sysfs interface atull
[not found] ` <1406932118-13885-4-git-send-email-atull-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2014-08-02 0:25 ` Pavel Machek
2014-08-05 18:18 ` [PATCH 0/3] Yet another stab at a fpga framework Pantelis Antoniou
2014-09-07 18:57 ` Pavel Machek
2014-09-08 21:00 ` atull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140809145024.GA6764@pollux.denx.de \
--to=pavel@denx.de \
--cc=akpm@linux-foundation.org \
--cc=atull@opensource.altera.com \
--cc=balbi@ti.com \
--cc=broonie@kernel.org \
--cc=cesarb@cesarb.net \
--cc=davem@davemloft.net \
--cc=davidb@codeaurora.org \
--cc=delicious.quinoa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kyle.teske@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=nico@linaro.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=philip@balister.org \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=rubini@gnudd.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sameo@linux.intel.com \
--cc=yvanderv@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).