From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support INn_MODE Date: Mon, 11 Aug 2014 11:06:06 +0100 Message-ID: <20140811100606.GB17745@leverpostej> References: <20140809173545.2fc1f72e@songinha-Samsung-DeskTop-System> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140809173545.2fc1f72e@songinha-Samsung-DeskTop-System> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Inha Song Cc: "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , "patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org" , "lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Pawel Moll , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" List-Id: devicetree@vger.kernel.org On Sat, Aug 09, 2014 at 09:35:45AM +0100, Inha Song wrote: > This patch update DT binding to support INn_MODE init_data > > Signed-off-by: Inha Song > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index 5c7e723..c21a30e 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -42,6 +42,11 @@ Optional properties: > the chip default will be used. If present exactly five values must > be specified. > > + - wlf,inmode : A list of INn_MODE register values. If absent, INn_MODE register > + set to 0 by default. The size of this list depends on ARIZONA_MAX_INPUT values. > + ARIZONA_MAX_INPUT is defined in include/linux/mfd/arizona/pdata.h. If present, > + exactly ARIZONA_MAX_INPUT values must be specified. Please don't refer to Linux internals here. How many INn_MODE registers can this hardware have? Why does this need to be overriden? Please mention this in the commit message and documentation. Why is exposing a raw register value the best way of doing this? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html