From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 2/2] media: adv7604: Add ability to read default input port from DT Date: Wed, 13 Aug 2014 17:24:40 +0100 Message-ID: <20140813162439.GG32644@leverpostej> References: <1407758719-12474-1-git-send-email-ian.molton@codethink.co.uk> <1407758719-12474-3-git-send-email-ian.molton@codethink.co.uk> <20140811121902.GA16295@leverpostej> <20140813131435.e0da6946bcd69e04a2305ef9@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140813131435.e0da6946bcd69e04a2305ef9@codethink.co.uk> Content-Language: en-US Sender: linux-media-owner@vger.kernel.org To: Ian Molton Cc: "linux-media@vger.kernel.org" , "laurent.pinchart@ideasonboard.com" , "hans.verkuil@cisco.com" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "lars@metafoo.de" , "shubhrajyoti@ti.com" , "william.towle@codethink.co.uk" List-Id: devicetree@vger.kernel.org On Wed, Aug 13, 2014 at 01:14:35PM +0100, Ian Molton wrote: > On Mon, 11 Aug 2014 13:19:02 +0100 > Mark Rutland wrote: > > > > - - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge. > > > + - pclk-sample: Pixel clock polarity. Defaults to output on the falling edge. > > > > Unrelated whitespace change? > > Is there a sensible way to get miniscule whitespace changes in? Just mention it in the commit message. > > > If none of hsync-active, vsync-active and pclk-sample is specified the > > > endpoint will use embedded BT.656 synchronization. > > > > > > + - default-input: Select which input is selected after reset. > > > > Valid values are? > > Chip dependent. 0 for 7611, 0-1 for 7612, I expect there are other chips in the family with differing numbers of inputs. Ok. Can this be mentioned in the documentation? Cheers, Mark. > > > + if (!of_property_read_u32(endpoint, "default_input", &v)) > > > > This doesn't match the binding ('_' vs '-'). > > Good catch! > > -- > Ian Molton > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >