From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Markus Pargmann <mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Steven Rostedt"
<rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org
Subject: Re: [PATCH v3 0/7] net: cpsw: Support for am335x chip MACIDs
Date: Sat, 16 Aug 2014 11:55:53 -0500 [thread overview]
Message-ID: <20140816165549.GC2858@katana> (raw)
In-Reply-To: <1408202315-20006-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Sat, Aug 16, 2014 at 05:18:28PM +0200, Markus Pargmann wrote:
> Hi,
>
> This series adds support to the cpsw driver to read the MACIDs of the am335x
> chip and use them as fallback. These addresses are only used if there are no
> mac addresses in the devicetree, for example set by a bootloader.
>
> In v3 I removed the previously seperate driver and included the changes into
> the main cpsw driver. I now check for a am33xx machine to not make this
> operation when running on davinci.
>
> Patches 1-4 are some minor fixes for the cpsw driver.
> Patch 5 adds the readout support.
> Patches 6 and 7 are for am33xx.dtsi to actually enable this feature.
Minor comments, but in general, looks good to me:
Reviewed-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Tests on real HW need to wait another 9 days...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-08-16 16:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-16 15:18 [PATCH v3 0/7] net: cpsw: Support for am335x chip MACIDs Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 1/7] DT doc: net: cpsw mac-address is optional Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 2/7] net: cpsw: Add missing return value Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 3/7] net: cpsw: header, Add missing include Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 4/7] net: cpsw: Replace pr_err by dev_err Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 5/7] net: cpsw: Add am33xx MACID readout Markus Pargmann
2014-08-16 16:46 ` Wolfram Sang
2014-08-18 6:58 ` Markus Pargmann
2014-08-16 16:53 ` Wolfram Sang
2014-08-18 7:03 ` Markus Pargmann
2014-08-18 18:24 ` Mugunthan V N
2014-08-18 19:41 ` Steven Rostedt
2014-08-18 19:58 ` Mugunthan V N
2014-08-18 20:57 ` Steven Rostedt
2014-08-18 22:50 ` Javier Martinez Canillas
2014-08-19 8:50 ` Markus Pargmann
2014-08-19 16:37 ` Mugunthan V N
2014-08-16 15:18 ` [PATCH v3 6/7] am33xx: define syscon control module device node Markus Pargmann
2014-08-16 15:18 ` [PATCH v3 7/7] arm: dts: am33xx, Add syscon phandle to cpsw node Markus Pargmann
[not found] ` <1408202315-20006-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-08-16 16:55 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140816165549.GC2858@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).