From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 2/6] iommu/arm-smmu: add support for specifying regulators Date: Tue, 19 Aug 2014 14:00:05 +0100 Message-ID: <20140819130005.GP23128@arm.com> References: <1407891099-24641-1-git-send-email-mitchelh@codeaurora.org> <1407891099-24641-3-git-send-email-mitchelh@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1407891099-24641-3-git-send-email-mitchelh-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mitchel Humpherys Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Aug 13, 2014 at 01:51:35AM +0100, Mitchel Humpherys wrote: > On some power-constrained platforms it's useful to disable power when a > device is not in use. Add support for specifying regulators for SMMUs > and only leave power on as long as the SMMU is in use (attached). ... and for bypass mode? My comments for clks largely apply here too -- I'd much rather see this in domain_init/domain_destroy with appropriate refcounting. It's just too much of a mess having these calls littered around the driver. Will